Nested Anonymous Functions Causing False Negative [PSR2]

[baileylo]

The following code sample is valid in 1.5 but causes errors in 2.0.

bar([
    'foo' => foo(function () {
        return 'foo';
    })
]);

$ php vendor/bin/phpcs --standard=PSR2 -sv test.php
Registering sniffs in the PSR2 standard... DONE (40 sniffs registered)
Creating file list... DONE (1 files in queue)
Changing into directory /var/lib/phpcs-test/
Processing test.php [PHP => 35 tokens in 7 lines]... DONE in 3ms (1 errors, 0 warnings)

FILE: /var/lib/phpcs-test/test.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces, found 0
   |       |     (Generic.WhiteSpace.ScopeIndent.Incorrect)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 25ms; Memory: 3.5Mb

I tested this specifically on 2.0.0, but am seeing it on master as well.

[aik099]

Can you please provide the output of that command (please add -sv flag so that sniff name will also be printed).

P.S.
This is 4th closure-indentation related report this week. I guess closures do become very popular lately.

[baileylo]

@aik099 I updated the original issue to contain the output of the command.

[gsherwood]

Thanks for reporting. I've fixed this issue now.

[aik099]

@gsherwood I guess that major rewrite of ScopeIndent sniff was bad idea in retrospect. The sniff version from 1.5.x versions was doing well for all these closure-related situations (just a guess).

[gsherwood]

Absolutely not a bad idea. It was essential to ensure scope indents are checked and fixed correctly for mixed PHP and HTML code, as well as JS files.

There is a lot of code I see that others probably don't :) You probably just didn't encounter all the bugs that were in it.

[aik099]

You probably just didn't encounter all the bugs that were in it.

Lucky me 😄 I always was wondering that none of closure usage related issues were reported while people were using 1.5. So my guess was that they were introduced in 2.0 version. I guess I was wrong then.