Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for git creation date localized #2551

Closed
timvink opened this issue Apr 12, 2021 · 2 comments · Fixed by #2579
Closed

Add support for git creation date localized #2551

timvink opened this issue Apr 12, 2021 · 2 comments · Fixed by #2579
Labels
change request Issue requests a new feature or improvement

Comments

@timvink
Copy link
Contributor

timvink commented Apr 12, 2021

Description

Hi @squidfunk! I just released mkdocs-git-revision-date-localized-plugin v0.9, which adds a new tag page.meta.git_creation_date_localized (implemented by @PegasisForever).

I'd like to offer native support for that tag as well in mkdocs-material. It's backwards compatible; if a user specifies enable_creation_date: true, the creation dates should also show up.

Implementation-wise, that means:

  • Updating the source-date.html partial with an additional if/else
  • Updating all translation files, with a new label ('Created: '), with some basic translations filled by using google translate.
  • Remove instructions on how to setup the partial override for mkdocs-material in our own docs

Would you be open to a PR for this?

Use Cases

  • See page creation date.

Screenshots / Mockups

image

@squidfunk
Copy link
Owner

Thanks for suggesting. Yes, you can open a PR and add support!

@squidfunk squidfunk added the change request Issue requests a new feature or improvement label Apr 12, 2021
@squidfunk
Copy link
Owner

Moving to discussions, since this issue was essentially a question.

Repository owner locked and limited conversation to collaborators Apr 18, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
change request Issue requests a new feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants