Skip to content

Commit c7d770b

Browse files
committed
Refactored other browser observables, removed memleaks
1 parent 8a6b89f commit c7d770b

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/assets/javascripts/browser/location/base/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@ export function watchLocationBase(
5151
.toString()
5252
.replace(/\/$/, "")
5353
),
54-
shareReplay(1)
54+
shareReplay({ bufferSize: 1, refCount: true })
5555
)
5656
}

src/assets/javascripts/browser/media/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ export function watchMedia(query: string): Observable<boolean> {
4141
)
4242
.pipe(
4343
startWith(media.matches),
44-
shareReplay(1)
44+
shareReplay({ bufferSize: 1, refCount: true })
4545
)
4646
}

src/assets/javascripts/browser/viewport/_/index.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export function watchViewport(): Observable<Viewport> {
7878
])
7979
.pipe(
8080
map(([offset, size]) => ({ offset, size })),
81-
shareReplay(1)
81+
shareReplay({ bufferSize: 1, refCount: true })
8282
)
8383
}
8484

@@ -116,7 +116,6 @@ export function watchViewportAt(
116116
y: offset.y - y + height
117117
},
118118
size
119-
})),
120-
shareReplay(1)
119+
}))
121120
)
122121
}

0 commit comments

Comments
 (0)