Replace built-in logformat referrer#2430
Conversation
|
Implementing request from Alex: "we should not hard code log formats". |
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
Amos: Implementing request from Alex: "we should not hard code log formats".
That was not a request. I do welcome this change (although not this PR -- we need to resolve the backlog problem before such PRs can become welcomed).
| { | ||
| const char *referer = nullptr; | ||
| if (al->request) | ||
| referer = al->request->header.getStr(Http::HdrType::REFERER); |
There was a problem hiding this comment.
Please disclose, in release notes, the functionality differences introduced by this PR. For example, AFAICT, Squid will now quote1 logged Referer header field values. If there are absolutely no formatting differences, please say so explicitly in the PR description.
Footnotes
-
Here, "quote" is referring to
Format::assemble()code associated with a truequotevariable value. ↩
2 participants
No description provided.