action {}, eventHandler {} with no debugging name is deprecated

Logs of actions are nearly useless if they have no name. Let's stop making things so convenient that we go blind.

Author: rjrjr

benchmarks/performance-poetry/complex-poetry/src/main/java/com/squareup/benchmarks/performance/complex/poetry/MaybeLoadingGatekeeperWorkflow.kt

@@ -32,7 +32,7 @@ class MaybeLoadingGatekeeperWorkflow<T : Any>(
     context: RenderContext
   ): MayBeLoadingScreen {
     context.runningWorker(isLoading.asTraceableWorker("GatekeeperLoading")) {
-      action {
+      action("GatekeeperLoading") {
         state = it
       }
     }

benchmarks/performance-poetry/complex-poetry/src/main/java/com/squareup/benchmarks/performance/complex/poetry/PerformancePoemWorkflow.kt

@@ -122,7 +122,7 @@ class PerformancePoemWorkflow(
           },
           "initializing"
         ) {
-          action {
+          action("initializing") {
             isLoading.value = false
             state = Selected(NO_SELECTED_STANZA)
           }
@@ -148,7 +148,7 @@ class PerformancePoemWorkflow(
                 }
               }.asTraceableWorker("EventRepetition")
             ) {
-              action {
+              action("currentStateIsLoading delay") {
                 (state as? ComplexCall)?.let { currentState ->
                   // Still repeating the complex call
                   state = ComplexCall(
@@ -167,7 +167,7 @@ class PerformancePoemWorkflow(
                 // is already in the state.
               }
             ) {
-              action {
+              action("loaded") {
                 isLoading.value = false
                 (state as? ComplexCall)?.let { currentState ->
                   state = Selected(currentState.payload)

benchmarks/performance-poetry/complex-poetry/src/main/java/com/squareup/benchmarks/performance/complex/poetry/PerformancePoemsBrowserWorkflow.kt

@@ -55,17 +55,17 @@ class PerformancePoemsBrowserWorkflow(
   StatefulWorkflow<ConfigAndPoems, State, Unit, OverviewDetailScreen<*>>() {
 
   sealed class State {
-    object Recurse : State()
+    data object Recurse : State()
 
     // N.B. This state is a smell. We include it to be able to mimic smells
     // we encounter in real life. Best practice would be to fold it
     // into [NoSelection] at the very least.
-    object Initializing : State()
+    data object Initializing : State()
     data class ComplexCall(
       val payload: Int
     ) : State()
 
-    object NoSelection : State()
+    data object NoSelection : State()
     data class Selected(val poemIndex: Int) : State()
   }
 
@@ -122,7 +122,7 @@ class PerformancePoemsBrowserWorkflow(
           props = nextProps,
           key = "${nextProps.first},${nextProps.second}",
         ) {
-          action {
+          action("setOutput") {
             setOutput(it)
           }
         }
@@ -134,7 +134,7 @@ class PerformancePoemsBrowserWorkflow(
       is Initializing -> {
         context.runningWorker(TraceableWorker.from("BrowserInitializing") { Unit }, "init") {
           isLoading.value = true
-          action {
+          action("onInitialized") {
             isLoading.value = false
             state = NoSelection
           }
@@ -178,7 +178,7 @@ class PerformancePoemsBrowserWorkflow(
                 // is already in the state.
               }
             ) {
-              action {
+              action("onComplexCall") {
                 isLoading.value = false
                 (state as? ComplexCall)?.let { currentState ->
                   state = if (currentState.payload != NO_POEM_SELECTED) {
@@ -229,7 +229,7 @@ class PerformancePoemsBrowserWorkflow(
 
   private fun choosePoem(
     index: Int
-  ) = action {
+  ) = action("choosePoem") {
     state = if (simulatedPerfConfig.isComplex) {
       ComplexCall(payload = index)
     } else {

samples/compose-samples/src/main/java/com/squareup/sample/compose/hellocompose/HelloComposeWorkflow.kt

@@ -19,7 +19,7 @@ object HelloComposeWorkflow : StatefulWorkflow<Unit, State, Nothing, HelloCompos
     }
   }
 
-  private val helloAction = action {
+  private val helloAction = action("hello") {
     state = state.theOtherState()
   }
 

samples/compose-samples/src/main/java/com/squareup/sample/compose/hellocomposebinding/HelloWorkflow.kt

@@ -28,7 +28,7 @@ object HelloWorkflow : StatefulWorkflow<Unit, State, Nothing, Rendering>() {
     val onClick: () -> Unit
   ) : Screen
 
-  private val helloAction = action {
+  private val helloAction = action("hello") {
     state = state.theOtherState()
   }
 

samples/compose-samples/src/main/java/com/squareup/sample/compose/hellocomposeworkflow/ComposeWorkflowImpl.kt

@@ -76,5 +76,5 @@ internal class ComposeWorkflowImpl<PropsT, OutputT : Any>(
   // Compiler bug doesn't let us call Snapshot.EMPTY.
   override fun snapshotState(state: State<PropsT, OutputT>): Snapshot = Snapshot.of("")
 
-  private fun forwardOutput(output: OutputT) = action { setOutput(output) }
+  private fun forwardOutput(output: OutputT) = action("forwardOutput") { setOutput(output) }
 }

samples/compose-samples/src/main/java/com/squareup/sample/compose/hellocomposeworkflow/HelloWorkflow.kt

@@ -26,7 +26,7 @@ object HelloWorkflow : StatefulWorkflow<Unit, State, Nothing, ComposeScreen>() {
     }
   }
 
-  private val helloAction = action {
+  private val helloAction = action("hello") {
     state = state.theOtherState()
   }
 

samples/compose-samples/src/main/java/com/squareup/sample/compose/inlinerendering/InlineRenderingWorkflow.kt

@@ -40,7 +40,7 @@ object InlineRenderingWorkflow : StatefulWorkflow<Unit, Int, Nothing, Screen>()
     context: RenderContext
   ) = ComposeScreen {
     Box {
-      Button(onClick = context.eventHandler { state += 1 }) {
+      Button(onClick = context.eventHandler("increment") { state += 1 }) {
         Text("Counter: ")
         AnimatedCounter(renderState) { counterValue ->
           Text(counterValue.toString())

samples/compose-samples/src/main/java/com/squareup/sample/compose/nestedrenderings/RecursiveWorkflow.kt

@@ -73,11 +73,11 @@ object RecursiveWorkflow : StatefulWorkflow<Unit, State, Nothing, Screen>() {
 
   override fun snapshotState(state: State): Snapshot? = null
 
-  private fun addChild() = action {
+  private fun addChild() = action("addChild") {
     state = state.copy(children = state.children + 1)
   }
 
-  private fun reset() = action {
+  private fun reset() = action("reset") {
     state = State()
   }
 }

samples/compose-samples/src/main/java/com/squareup/sample/compose/textinput/TextInputWorkflow.kt

@@ -23,7 +23,7 @@ object TextInputWorkflow : StatefulWorkflow<Unit, State, Nothing, Rendering>() {
     val onSwapText: () -> Unit
   ) : Screen
 
-  private val swapText = action {
+  private val swapText = action("swapText") {
     state = state.copy(showingTextA = !state.showingTextA)
   }