Adopt Gradle 7.4 #7068
Merged
Adopt Gradle 7.4 #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Feb 8, 2022
.gitignore
Outdated
| @@ -35,3 +35,4 @@ docs/index.md | |||
|
|
|||
| # jenv | |||
| /.java-version | |||
| kotlin-js-store | |||
There was a problem hiding this comment.
Should we ignore this file?
There was a problem hiding this comment.
No. It is supposed to be checked in for reproducible builds.
Goooler
commented
Feb 8, 2022
| @@ -80,7 +80,6 @@ subprojects { | |||
| configure<JavaPluginExtension> { | |||
| toolchain { | |||
| languageVersion.set(JavaLanguageVersion.of(11)) | |||
| vendor.set(JvmVendorSpec.ADOPTOPENJDK) | |||
| } | |||
There was a problem hiding this comment.
ADOPTOPENJDK was deprecated, replace it with AZUL:
Execution failed for task ':okhttp:compileKotlinJvm'.
> Error while evaluating property 'kotlinJavaToolchainProvider.javaVersion' of task ':okhttp:compileKotlinJvm'
> Failed to calculate the value of property 'providedJvm$kotlin_gradle_plugin'.
> No compatible toolchains found for request filter: {languageVersion=11, vendor=AZUL, implementation=vendor-specific} (auto-detect true, auto-download true)
Any good solutions?
There was a problem hiding this comment.
If it works without this line, then go for it. The gradle team and the JDK providers don't seem to have a coordinated (public) plan for how these things work together yet. I asked in gradle issue tracker for a working example of their discovery API, and sounds like there isn't one. :(
There was a problem hiding this comment.
Yeah, I've also asked, but no solution.
This reverts commit 808a664.
yschimke
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.gradle.org/7.4/release-notes.html
The Version catalogs is promoted to a stable feature.