Upgrade Android and IOS version #237
Conversation
Upgrade Android version to 1.6.6 Upgrade IOS version to 1.6.3
mansi-square
force-pushed
the
mansi/upgrade_android_ios_version
branch
from
4e24368 to
9a242d7
Compare
|
Is there any information regarding when this will be merged given the June 15th deadline that is fast approaching? |
Updated react-native version to 0.74.1
|
@gregg062 we're currently working on getting CI to pass so we can merge this |
mansi-square
force-pushed
the
mansi/upgrade_android_ios_version
branch
from
87d2e69 to
40e7693
Compare
|
@mansi-square would be super appreciative if you can get this over the finish line we have 30k users who are going to lose the ability to pay with Mastercard support and have been trying to get this upgraded |
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Set up JDK 17 |
There was a problem hiding this comment.
Slightly surprised this comes in as a "upgrade version" PR... is it related to the version bump, or more a general improvement?
(Clearly we do need a good Java, so that's fine, but why didn't we have this-or-something-like-it previously? Given we didn't, why do we need this now?)
There was a problem hiding this comment.
For the new version of React-Native i.e 0.74.1 we need to use JDK 17 or else it was throwing error.
| @@ -301,7 +301,7 @@ private BuyerAction getBuyerAction(final String buyerActionString, final Money m | |||
| private long readCardEntryCloseExitAnimationDurationMs() { | |||
| long delayDurationMs = 0; | |||
| Resources.Theme theme = Objects.requireNonNull(getCurrentActivity()).getResources().newTheme(); | |||
| theme.applyStyle(R.style.sqip_Theme_CardEntry, true); | |||
| theme.applyStyle(R.style.sqip_ThemeCardEntry, true); | |||
There was a problem hiding this comment.
@WhatsEmo, am I right that this smells bad?
@mansi-square, I believe we tell users they can override the (previous) theme values to style their apps, so changing to an almost-same name and defining a new style below is potentially breaking to people who are customizing the styles. Are we gaining anything by this rename?
There was a problem hiding this comment.
am I right that this smells bad?
Yep, I think this would crash or not reference a theme at all since R.style.sqip_Theme_CardEntry is the resource value we ask developers to use.
There was a problem hiding this comment.
Ahh it wouldn't crash because <style name="sqip_ThemeCardEntry" parent="@style/Theme.AppCompat.DayNight.DarkActionBar" /> was added, but since the theme is set to a default Android style it wouldn't know what values to override when the develop follows https://developer.squareup.com/docs/in-app-payments-sdk/cookbook/customize-payment-form
There was a problem hiding this comment.
- Revert this, or find a way to update that allows the customization from our documented theming.
There was a problem hiding this comment.
With the new version of React-Native some modules are removed so the default style which android was providing is now removed and regarding to change in name even i was giving same name to the new style it was throwing duplicate name error.
| <application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning"> | ||
| <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> | ||
| </application> | ||
| <application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning"/> |
There was a problem hiding this comment.
Our direct IAP test app does not have usesCleartextTraffic... do we know what in the plugin quickstart uses raw http:// not https://?
| "lint": "eslint .", | ||
| "build:ios": "react-native bundle --entry-file='index.js' --bundle-output='./ios/main.jsbundle' --dev=false --platform='iOS'" |
There was a problem hiding this comment.
I'll trust you, but surprised that the ios build line vanished here. Not my swim lane, however; I assume it's somewhere else now!
|
|
|
Do you have any update regarding when this will be available? We are now less than 2 weeks away from the required upgrade date. |
|
Can someone from Square comment on when this will be available? There are customers depending on this so it would be professional to not leave them in the dark. |
Upgrade Android version to 1.6.6
Upgrade IOS version to 1.6.3