Add complete external file format options parsing support

- Add SERDE_METHOD and DATA_COMPRESSION as top-level options
- Add ExternalFileFormatUseDefaultTypeOption for USE_TYPE_DEFAULT
- Change ExternalFileFormatLiteralOption.Value to ScalarExpression
  to support both StringLiteral and IntegerLiteral
- Handle FIRST_ROW as IntegerLiteral

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: kyleconroy

ast/external_statements.go

@@ -43,11 +43,19 @@ func (o *ExternalFileFormatContainerOption) externalFileFormatOption() {}
 // ExternalFileFormatLiteralOption represents a literal value option
 type ExternalFileFormatLiteralOption struct {
 	OptionKind string
-	Value      *StringLiteral
+	Value      ScalarExpression // Can be StringLiteral or IntegerLiteral
 }
 
 func (o *ExternalFileFormatLiteralOption) externalFileFormatOption() {}
 
+// ExternalFileFormatUseDefaultTypeOption represents USE_TYPE_DEFAULT option
+type ExternalFileFormatUseDefaultTypeOption struct {
+	OptionKind                       string
+	ExternalFileFormatUseDefaultType string // "True" or "False"
+}
+
+func (o *ExternalFileFormatUseDefaultTypeOption) externalFileFormatOption() {}
+
 // CreateExternalTableStatement represents CREATE EXTERNAL TABLE statement
 type CreateExternalTableStatement struct {
 	SchemaObjectName     *SchemaObjectName

parser/marshal.go

@@ -16647,9 +16647,15 @@ func externalFileFormatOptionToJSON(opt ast.ExternalFileFormatOption) jsonNode {
 			"OptionKind": o.OptionKind,
 		}
 		if o.Value != nil {
-			node["Value"] = stringLiteralToJSON(o.Value)
+			node["Value"] = scalarExpressionToJSON(o.Value)
 		}
 		return node
+	case *ast.ExternalFileFormatUseDefaultTypeOption:
+		return jsonNode{
+			"$type":                              "ExternalFileFormatUseDefaultTypeOption",
+			"ExternalFileFormatUseDefaultType":   o.ExternalFileFormatUseDefaultType,
+			"OptionKind":                         o.OptionKind,
+		}
 	default:
 		return jsonNode{"$type": "UnknownExternalFileFormatOption"}
 	}

parser/parse_statements.go

@@ -8350,10 +8350,29 @@ func (p *Parser) parseCreateExternalFileFormatStatement() (*ast.CreateExternalFi
 				}
 				stmt.ExternalFileFormatOptions = append(stmt.ExternalFileFormatOptions, opt)
 			} else {
-				// Skip other options for now
+				// Handle other options (SERDE_METHOD, DATA_COMPRESSION) as literal options
+				optionKind := p.externalFileFormatOptionKind(optName)
 				if p.curTok.Type == TokenEquals {
 					p.nextToken() // consume =
-					p.nextToken() // consume value
+					// Parse value (string literal or identifier like FALSE/TRUE)
+					if p.curTok.Type == TokenString {
+						val, _ := p.parseStringLiteral()
+						stmt.ExternalFileFormatOptions = append(stmt.ExternalFileFormatOptions, &ast.ExternalFileFormatLiteralOption{
+							OptionKind: optionKind,
+							Value:      val,
+						})
+					} else {
+						// Handle identifiers like FALSE, TRUE, etc.
+						val := &ast.StringLiteral{
+							LiteralType: "String",
+							Value:       p.curTok.Literal,
+						}
+						p.nextToken()
+						stmt.ExternalFileFormatOptions = append(stmt.ExternalFileFormatOptions, &ast.ExternalFileFormatLiteralOption{
+							OptionKind: optionKind,
+							Value:      val,
+						})
+					}
 				}
 			}
 			if p.curTok.Type == TokenComma {
@@ -8400,6 +8419,35 @@ func (p *Parser) parseExternalFileFormatSuboption() ast.ExternalFileFormatOption
 
 	if p.curTok.Type == TokenEquals {
 		p.nextToken() // consume =
+
+		// Special handling for USE_TYPE_DEFAULT which uses ExternalFileFormatUseDefaultTypeOption
+		if optName == "USE_TYPE_DEFAULT" {
+			// Value is TRUE or FALSE (as identifier, not string)
+			value := strings.ToUpper(p.curTok.Literal)
+			defaultType := "False"
+			if value == "TRUE" {
+				defaultType = "True"
+			}
+			p.nextToken()
+			return &ast.ExternalFileFormatUseDefaultTypeOption{
+				OptionKind:                       optionKind,
+				ExternalFileFormatUseDefaultType: defaultType,
+			}
+		}
+
+		// Handle integer values for FIRST_ROW
+		if optName == "FIRST_ROW" {
+			val := &ast.IntegerLiteral{
+				LiteralType: "Integer",
+				Value:       p.curTok.Literal,
+			}
+			p.nextToken()
+			return &ast.ExternalFileFormatLiteralOption{
+				OptionKind: optionKind,
+				Value:      val,
+			}
+		}
+
 		val, _ := p.parseStringLiteral()
 		return &ast.ExternalFileFormatLiteralOption{
 			OptionKind: optionKind,
@@ -8427,6 +8475,8 @@ func (p *Parser) externalFileFormatOptionKind(name string) string {
 		return "DataCompression"
 	case "FIRST_ROW":
 		return "FirstRow"
+	case "SERDE_METHOD":
+		return "SerDeMethod"
 	default:
 		return name
 	}

parser/testdata/Baselines130_CreateExternalFileFormatStatementTests130/metadata.json

@@ -1 +1 @@
-{"todo": true}
+{}

parser/testdata/CreateExternalFileFormatStatementTests130/metadata.json

@@ -1 +1 @@
-{"todo": true}
+{}