Skip to content

Commit 885a7a7

Browse files
committed
0.6.0 setup
* remove use of LooseVersion Fixes: #20 * require sphinx >=4.0.0 * I think we're beta now * update pre commit / black etc
1 parent 290d305 commit 885a7a7

File tree

4 files changed

+36
-38
lines changed

4 files changed

+36
-38
lines changed

.pre-commit-config.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,27 @@
22
# See https://pre-commit.com/hooks.html for more hooks
33
repos:
44
- repo: https://github.com/python/black
5-
rev: 20.8b1
5+
rev: 23.3.0
66
hooks:
77
- id: black
88

99
- repo: https://github.com/sqlalchemyorg/zimports
10-
rev: master
10+
rev: v0.6.0
1111
hooks:
1212
- id: zimports
1313

1414
- repo: https://github.com/pycqa/flake8
15-
rev: master
15+
rev: 5.0.0
1616
hooks:
1717
- id: flake8
1818
additional_dependencies:
1919
- flake8-import-order
20+
- flake8-import-single==0.1.5
2021
- flake8-builtins
21-
- flake8-docstrings
22+
- flake8-future-annotations>=0.0.5
23+
- flake8-docstrings>=1.6.0
2224
- flake8-rst-docstrings
25+
# flake8-rst-docstrings dependency, leaving it here
26+
# in case it requires a version pin
2327
- pydocstyle
2428
- pygments
25-
26-
27-
28-

setup.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"descriptions to be linkable",
2525
long_description=open(readme).read(),
2626
classifiers=[
27-
"Development Status :: 3 - Alpha",
27+
"Development Status :: 4 - Beta",
2828
"Environment :: Console",
2929
"Framework :: Sphinx :: Extension",
3030
"Intended Audience :: Developers",
@@ -42,4 +42,8 @@
4242
packages=["sphinx_paramlinks"],
4343
include_package_data=True,
4444
zip_safe=False,
45+
install_requires=[
46+
"Sphinx>=4.0.0",
47+
"docutils",
48+
],
4549
)

sphinx_paramlinks/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
__version__ = "0.5.4"
1+
__version__ = "0.6.0"
22

33
from .sphinx_paramlinks import setup # noqa

sphinx_paramlinks/sphinx_paramlinks.py

Lines changed: 22 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
#!coding: utf-8
2-
from distutils.version import LooseVersion
32
from enum import Enum
43
import os
54
import re
65

76
from docutils import nodes
87
from docutils.transforms import Transform
9-
from sphinx import __version__
108
from sphinx import addnodes
119
from sphinx.domains import ObjType
1210
from sphinx.domains.python import ObjectEntry
@@ -31,6 +29,7 @@ def _is_html(app):
3129

3230
# https://www.sphinx-doc.org/en/master/extdev/deprecated.html
3331

32+
3433
# Constants for link styles
3534
class HyperlinkStyle(Enum):
3635
NONE = "none"
@@ -73,16 +72,20 @@ def _cvt_param(name, line):
7372
name = name[0:-9]
7473

7574
def cvt(m):
76-
role, modifier, objname, paramname = m.group(1), m.group(2) or "", name, m.group(3)
75+
role, modifier, objname, paramname = (
76+
m.group(1),
77+
m.group(2) or "",
78+
name,
79+
m.group(3),
80+
)
7781
refname = _refname_from_paramname(paramname, strip_markup=True)
7882
item = (
7983
"single",
8084
"%s (%s parameter)" % (refname, objname),
8185
"%s.params.%s" % (objname, refname),
8286
"",
8387
)
84-
if LooseVersion(__version__) >= LooseVersion("1.4.0"):
85-
item += (None,)
88+
item += (None,)
8689

8790
doc_idx.append(item)
8891
return ":%s %s_sphinx_paramlinks_%s.%s:" % (
@@ -93,7 +96,12 @@ def cvt(m):
9396
)
9497

9598
def secondary_cvt(m):
96-
role, modifier, objname, paramname = m.group(1), m.group(2) or "", name, m.group(3)
99+
role, modifier, objname, paramname = (
100+
m.group(1),
101+
m.group(2) or "",
102+
name,
103+
m.group(3),
104+
)
97105
return ":%s %s_sphinx_paramlinks_%s.%s:" % (
98106
role,
99107
modifier,
@@ -102,7 +110,9 @@ def secondary_cvt(m):
102110
)
103111

104112
line = re.sub(r"^:(keyword|param) ([^:]+? )?([^:]+?):", cvt, line)
105-
line = re.sub(r"^:(kwtype|type) ([^:]+? )?([^:]+?):", secondary_cvt, line)
113+
line = re.sub(
114+
r"^:(kwtype|type) ([^:]+? )?([^:]+?):", secondary_cvt, line
115+
)
106116
return line
107117

108118
if what in ("function", "method", "class"):
@@ -383,27 +393,11 @@ def build_index(app, doctree):
383393
doc_entries = entries[docname]
384394
_indexentries(app.env)[docname].extend(doc_entries)
385395

386-
if LooseVersion(__version__) >= LooseVersion("4.0.0"):
387-
for entry in doc_entries:
388-
sing, desc, ref, extra = entry[:4]
389-
app.env.domains["py"].data["objects"][ref] = ObjectEntry(
390-
docname, ref, "parameter", False
391-
)
392-
elif LooseVersion(__version__) >= LooseVersion("3.0.0"):
393-
for entry in doc_entries:
394-
sing, desc, ref, extra = entry[:4]
395-
app.env.domains["py"].data["objects"][ref] = ObjectEntry(
396-
docname,
397-
ref,
398-
"parameter",
399-
)
400-
else:
401-
for entry in doc_entries:
402-
sing, desc, ref, extra = entry[:4]
403-
app.env.domains["py"].data["objects"][ref] = (
404-
docname,
405-
"parameter",
406-
)
396+
for entry in doc_entries:
397+
sing, desc, ref, extra = entry[:4]
398+
app.env.domains["py"].data["objects"][ref] = ObjectEntry(
399+
docname, ref, "parameter", False
400+
)
407401

408402
_indexentries(app.env).pop("_sphinx_paramlinks_index")
409403

0 commit comments

Comments
 (0)