Skip to content

In SELECT ... INTO, the INTO should be on a separate line #864

Open
@tordans

Description

@tordans

Describe the Feature

Right now, the INTO is placed at the end of the last SELECT line.
This makes it quite hard to see.
When parsing the commands, I see SELECT but nothing that signals that this will create or modify a table. In fact, when I remove the INTO name, the formatting does not change.

I suggest to place the INTO on a new line to give it more visibility.

Currently:

SELECT
  r.*,
  nrm.idx INTO parking_driveways
FROM
  _parking_roads r
  JOIN _parking_node_road_mapping nrm ON r.osm_id = nrm.way_id
  JOIN parking_intersections i ON nrm.node_id = i.node_id
WHERE
  i.service_degree > 0
  AND i.degree <> i.service_degree
  AND r.is_service;

Improved:

SELECT
  r.*,
  nrm.idx
INTO parking_driveways
FROM
  _parking_roads r
  JOIN _parking_node_road_mapping nrm ON r.osm_id = nrm.way_id
  JOIN parking_intersections i ON nrm.node_id = i.node_id
WHERE
  i.service_degree > 0
  AND i.degree <> i.service_degree
  AND r.is_service;

Why do you want this feature?

I consider the INTO even more important than the SELECT but is has a lot less visibility ATM.


Interesting enough the Github code highlighting does not recognize INTO either…

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions