Customize PLSQL dialect to support bind variables with array notation

[raffian]

We're using the plsql formatter for parsing Pro*C SQL. It's proprietary to Oracle but it's basically PL/SQL with some minor C-based spiciness sprinkled on top. The plsql formatter handles 99% of our needs except for statements containing array-based bind variables:

SELECT col1 from table1 where col1 = :param[i];


Error: Parse error: Unexpected "[i];" at line 1 column 44.
SQL dialect used: "plsql".
    at T.default.createParseError (https://unpkg.com/sql-formatter@latest/dist/sql-formatter.min.js:1:233841)
    at T.default.tokenize (https://unpkg.com/sql-formatter@latest/dist/sql-formatter.min.js:1:233607)
    at T.default.tokenize (https://unpkg.com/sql-formatter@latest/dist/sql-formatter.min.js:1:228909)

The same error is not raised, however, using TSQL formatter. After comparing the two formatters we believe identTypes parameter in <dialect>.formatter.ts might be the cause as plsql does not have '[]' like tsql does .

# plsql
identTypes: [`""-qq`],

# tsql
identTypes: [`""-qq`, '[]'],

We have not yet tested this solution - are we at least on the right path?

[nene]

This might work, but what you'd be saying to the formatter to treat [...] syntax as identifiers, which is kinda odd. It will also likely result in space between :param and [i].

I think a better way would be to use the paramTypes config to define a custom rule to recognize parameters like that. Something like:

paramTypes: {
  custom: [{ regex: ':\\w+\\[\\w+\\]' }],
}

Or alternatively you could supply the extraParens option to recognize [,] parenthesis pairs:

extraParens: ['[]'],

[raffian]

I will try these, thank you!