Skip to content

Conversation

@osdiab
Copy link

@osdiab osdiab commented Mar 30, 2025

Not sure if this actually works as I haven't tried it at all and don't really know how to as I've never worked on a VSCode extension before, but I think something like this should work?

Closes sql-formatter-org/sql-formatter#760 maybe.

@nene
Copy link
Contributor

nene commented Mar 30, 2025

Thanks for the pull request.

It would be nice though if you took the time to verify by yourself whether it works. I personally have also fairly little experience with VSCode extension development. I didn't write the original extension. I'm just occasionally maintaining it. I won't be able to just look at the code and say yes this looks good to me. I'd assume you've implemented this as you're personally interested in using this feature. It would then really be in your interests to make sure it works as you're intending it to work.

Is there something in particular that stops you from testing it out? Or do you have some concerns about your implementation you're particularly unsure of?

@jpenna
Copy link

jpenna commented Jul 15, 2025

It should default to .sql-formatter.json, as per the CLI tool documentation.

@joseluisgonzalezca
Copy link

Will this feature be merged anytime soon? Is there something that prevents it from being published?

@nene
Copy link
Contributor

nene commented Nov 14, 2025

Well, the author of this pull request said that he hasn't tested it and doesn't know if it actually works.

I haven't bothered to test it either as that feature is not high in my priorities list. If you're interested in it, you could try it out and let me know if this actually works.

Somebody already raised a concern about the default config file path. That's likely not a blocker and can be implemented later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VSCode] Feature Request: Support JSON config file

4 participants