fix: using logical id instead alarmName

In DependsOn use the Physical ID of the resource instead the concatenate alarm name

Author: ralfonsoreyes

src/index.js

@@ -593,20 +593,26 @@ class AlertsPlugin {
             resourcesKeys.length === 0 ||
             resourcesKeys.indexOf(resource) !== -1)
       )
-      .map((key) => resources[key]);
+      .map((key) => ({
+        cfLogicalId: key,
+        cfResource: resources[key],
+      }));
   }
 
-  _resolveAlarmsNames(definition) {
+  _resolveAlarmsPhysicalLogicalIds(definition) {
     return this._getFilteredResourcesAsArray(
       definition.alarmsToInclude,
       'AWS::CloudWatch::Alarm',
       true
-    ).map((resource) => resource.Properties.AlarmName);
+    ).map((filteredResource) => ({
+      cfLogicalId: filteredResource.cfLogicalId,
+      cfPhysicalId: filteredResource.cfResource.Properties.AlarmName,
+    }));
   }
 
-  _resolveAlarmRules(alarmsNames) {
-    const alarmRule = alarmsNames
-      .map((alarmName) => `ALARM(${alarmName})`)
+  _resolveAlarmRules(physicalLogicalIds) {
+    const alarmRule = physicalLogicalIds
+      .map((physicalLogicalId) => `ALARM(${physicalLogicalId.cfPhysicalId})`)
       .join(' OR ');
 
     return alarmRule;
@@ -641,9 +647,10 @@ class AlertsPlugin {
     Object.keys(definitions).forEach((definitionName) => {
       const definition = definitions[definitionName];
       if (definition.type === 'composite' && definition.enabled !== false) {
-        const alarmsNames = this._resolveAlarmsNames(definition);
+        const physicalLogicalIds =
+          this._resolveAlarmsPhysicalLogicalIds(definition);
         // only create the composite alarm if there is at least one alarm to include
-        if (alarmsNames?.length > 0) {
+        if (physicalLogicalIds?.length > 0) {
           const cf = {};
           const { cfResource, cfName } = this._getCfResourceAndName(
             'Composite',
@@ -656,10 +663,10 @@ class AlertsPlugin {
               AlarmName: cfName,
               AlarmDescription: definition.description,
               ActionsEnabled: definition.actionsEnabled,
-              AlarmRule: this._resolveAlarmRules(alarmsNames),
+              AlarmRule: this._resolveAlarmRules(physicalLogicalIds),
               AlarmActions: alarmActions,
             },
-            DependsOn: alarmsNames,
+            DependsOn: physicalLogicalIds.map((alarm) => alarm.cfLogicalId),
           };
 
           cf[cfResource] = compositeAlarm;

src/index.test.js

@@ -1703,7 +1703,7 @@ describe('#index', () => {
             AlarmRule: 'ALARM(fooservice-dev-foo-successRateDrop)',
             AlarmActions: [{ Ref: 'AwsAlertsAlarm' }],
           }),
-          DependsOn: ['fooservice-dev-foo-successRateDrop'],
+          DependsOn: ['FooSuccessRateDropAlarm'],
         },
       });
     });
@@ -1747,10 +1747,7 @@ describe('#index', () => {
               'ALARM(fooservice-dev-foo-successRateDrop) OR ALARM(fooservice-dev-foo1-successRateDrop)',
             AlarmActions: [{ Ref: 'AwsAlertsAlarm' }],
           }),
-          DependsOn: [
-            'fooservice-dev-foo-successRateDrop',
-            'fooservice-dev-foo1-successRateDrop',
-          ],
+          DependsOn: ['FooSuccessRateDropAlarm', 'Foo1SuccessRateDropAlarm'],
         },
       });
     });
@@ -1859,10 +1856,7 @@ describe('#index', () => {
               'ALARM(fooservice-dev-foo-successRateDrop) OR ALARM(fooservice-dev-foo1-successRateDrop)',
             AlarmActions: [{ Ref: 'AwsAlertsAlarm' }],
           }),
-          DependsOn: [
-            'fooservice-dev-foo-successRateDrop',
-            'fooservice-dev-foo1-successRateDrop',
-          ],
+          DependsOn: ['FooSuccessRateDropAlarm', 'Foo1SuccessRateDropAlarm'],
         },
       });
     });