Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to handle light mode as a separate class #2551

Closed
goanpeca opened this issue Jul 17, 2015 · 4 comments
Closed

Refactor code to handle light mode as a separate class #2551

goanpeca opened this issue Jul 17, 2015 · 4 comments
Assignees

Comments

@goanpeca
Copy link
Member

Currently the code inside spyder.py is a bit convoluted because if not light appears in a lot of places.

This change would make the code easier to read and maintain, and still keep the light mode in case there is people still using it.

@goanpeca goanpeca self-assigned this Jul 17, 2015
@goanpeca goanpeca added this to the wishlist milestone Jul 17, 2015
@ccordoba12
Copy link
Member

We should put a date to this one. I'd prefer to have it for 3.0, to test things very well and don't add possibly disruptive changes in 3.1.

Thoughts @goanpeca?

@goanpeca
Copy link
Member Author

Should be quite fast to do, so I will do it tonight and we can move on with fast things first.

We still have a pending hangout to go over projects, let me know when ;-)

@goanpeca goanpeca modified the milestones: v3.0, wishlist Jul 21, 2015
@ccordoba12
Copy link
Member

We still have a pending hangout to go over projects, let me know when ;-)

Yep, I know, but please focus first on issue #2555, so we can release beta1.

@ccordoba12 ccordoba12 removed this from the v3.0 milestone Dec 19, 2015
@ccordoba12
Copy link
Member

I finally decided to remove light mode. See PR #2874 for my reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants