fix inaccurate line numbers #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this one took a while Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
|
Really happy to hear that you find the package useful. 🙂 Thanks for the PR. Should I merge this or wait for the tests ? ( We definitely need more thorough testing for a lot of things ). |
|
@vito Many thanks for the PR. And yes, a test would be most welcome! Also, please feel free to link us to your Lisp project when you feel it's ready, and we'll be happy to link to it. I've been planning to add a list of "projects using Slurp". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This is a really cool package. I'm working on a new Lisp and it'd be great to use this package along the way.
I noticed line numbers in error messages seemed way off in a couple experiments, and finally tracked it down to a missing
*.I don't see any tests that cover error locations - happy to write one, just submitting this before I forget to.