-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking changes in v1.7.0 without notice - no migration path given #1000
Comments
Welcome to Springwolf. Thanks a lot for reporting your first issue. Please check out our contributors guide and feel free to join us on discord. |
Hi @talbx,
We consider most public interfaces as public APIs (i.e. We welcome you to participate at Springwolf. Also, we have started on #805. Feel free to comment, implement and/or test so that there is no need for private customization. |
Hi @timonback, thanks for the feedback! Well you are completely right, we should just stick to the interfaces 😄 . Since you started working on #805, we are pausing the upgrade to v1.7.0, because with finalization of said issue, our efforts become obsolete anyway. I will clarify in which manner we can assist you; e.g with further input or actual code contributions. This issue can be closed then! Thank you! |
Hi @talbx, We are looking forward to your feedback |
Describe the bug
Public APIs such as the
AsyncAnnotationScanner
were removed / altered in a breaking manner.In the release notes for v1.7.0 nothing is mentioned regarding this.
A migration path for consumers of those changed / deleted public classes is missing.
Upgrading to v1.7.0 (in my case from v1.6.0) is breaking the build.
Dependencies and versions used
springwolf-core
version1.7.0
.Code example
See this commit fa63e49.
Multiple classes were deleted, multiple classes were moved into different packages, such as the
AsyncAnnotationProvider
ps: my team is using e.g
AsyncAnnotationScanner
andAsyncAnnotationProvider
to help supporting multi-spec async API in our project. For more info see #805ps²: are u generally using semver? if yes then this release number should be re-evaluated
Stack trace and error logs
The text was updated successfully, but these errors were encountered: