Add ServerBaseUrlCustomizer functionality to be able to customize the generated Server URL #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylar-stark
changed the title
|
Use case: strip the "context-path" off the generated server URL and instead add it to the beginning of each path, so that Open API generation works behind a reverse proxy |
… generated server base URL
|
Could you add the corresponding unit tests to your PR? |
|
@bnasslahsen Unit test added. Thanks! |
|
Thank you for your contribution ! |
bnasslahsen
added a commit
that referenced
this pull request
Mar 22, 2022
…to customize the generated Server URL. Fixes #1543.
| /** | ||
| * The server base URL customisers. | ||
| */ | ||
| private final Optional<List<ServerBaseUrlCustomizer>> serverBaseUrlCustomisers; |
There was a problem hiding this comment.
Weird pattern to use Optional for class vars when the code has to check if it's null anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerBaseUrlCustomiser to allow making changes to the generated server base URL. Also adds a getter method for retrieving the generated server base URL to use in an OpenApiBuilderCustomizer in order to make customizations based on the generated value