-
-
Notifications
You must be signed in to change notification settings - Fork 526
Add support for caching based on Locale #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
28217cb
to
e92172f
Compare
Thank you @ianwallen for your efforts. Once corrected, i will proceed with the merge. |
Finally got it working - sorry for all the commits - I was having problems running all the test on my local system. |
@bnasslahsen https://sites.google.com/site/openjdklocale/design-notes/resource-bundle-lookup-order So if someone is using different message files for en_US and en_UK, they would both be using the same "en" language cache so it would just load the first occurrence into the cache map. I was originally going to use the Locale in the map however I was not sure if the Locale would work correctly during the lookup and after finding the following it seems like it could get more complicated that I wanted to go. http://www.java2s.com/Code/Java/Collections-Data-Structure/MapusingLocaleobjectsaskeys.htm Not sure if you want to leave it as is or flag this as a future enhancement? |
I would say that if you feel confident about this enhancement, you can submit another PR. |
Add support for caching based on Locale. - Fixed #1354