Fix sonarqube errors

Author: bnasslahsen

springdoc-openapi-starter-common-mcp/src/main/java/org/springdoc/ai/dashboard/McpSyncServerDashboardToolSource.java

@@ -210,11 +210,8 @@ private Map<String, Type> scanToolReturnTypes(ApplicationContext applicationCont
 				}
 			}
 		}
-		catch (ClassNotFoundException ex) {
-			// @McpTool annotation not on classpath — no return types available
-		}
 		catch (Exception ex) {
-			// Scanning failed — ignore
+			// @McpTool annotation not on classpath, or scanning failed — no return types available
 		}
 		return returnTypes;
 	}

springdoc-openapi-starter-common-mcp/src/main/java/org/springdoc/ai/mcp/McpAuditLogger.java

@@ -31,6 +31,7 @@
 import java.time.format.DateTimeFormatter;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Consumer;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -103,7 +104,7 @@ public class McpAuditLogger {
 	 * Optional in-memory sink set by {@link org.springdoc.ai.dashboard.McpAuditEventStore}
 	 * when the dashboard is active. {@code null} when the dashboard is not in use.
 	 */
-	private static volatile Consumer<String> eventSink;
+	private static final AtomicReference<Consumer<String>> EVENT_SINK = new AtomicReference<>();
 
 	private McpAuditLogger() {
 	}
@@ -115,7 +116,7 @@ private McpAuditLogger() {
 	 * @param sink the consumer to register, or {@code null} to unregister
 	 */
 	public static void setEventSink(Consumer<String> sink) {
-		eventSink = sink;
+		EVENT_SINK.set(sink);
 	}
 
 	/**
@@ -218,7 +219,7 @@ static void log(AuditRecord record) {
 
 			String json = MAPPER.writeValueAsString(root);
 			AUDIT_LOGGER.info(json);
-			Consumer<String> sink = eventSink;
+			Consumer<String> sink = EVENT_SINK.get();
 			if (sink != null) {
 				sink.accept(json);
 			}
@@ -275,11 +276,8 @@ private static SecurityInfo extractSecurityInfo() {
 				}
 			}
 		}
-		catch (ClassNotFoundException ignored) {
-			// Spring Security not on classpath
-		}
 		catch (Exception ignored) {
-			// No authentication context or reflection failure
+			// Spring Security not on classpath, or no authentication context / reflection failure
 		}
 		return info;
 	}

springdoc-openapi-starter-common-mcp/src/main/java/org/springdoc/ai/mcp/McpCommunityToolAuditAspect.java

@@ -111,6 +111,7 @@ private String extractToolName(ProceedingJoinPoint pjp) {
 					return (name != null && !name.isBlank()) ? name : sig.getMethod().getName();
 				}
 				catch (Exception ignored) {
+					// Fall back to the method name if the annotation's name() cannot be read
 				}
 			}
 		}

springdoc-openapi-starter-common-mcp/src/main/java/org/springdoc/ai/mcp/OpenApiMcpToolCallbackProvider.java

@@ -31,6 +31,7 @@
 import java.util.Locale;
 import java.util.Map;
 import java.util.Optional;
+import java.util.concurrent.atomic.AtomicReference;
 
 import io.swagger.v3.oas.models.OpenAPI;
 import io.swagger.v3.oas.models.PathItem;
@@ -95,7 +96,7 @@ public class OpenApiMcpToolCallbackProvider implements ToolCallbackProvider {
 	/**
 	 * Cached tool callbacks, built lazily from the OpenAPI specification.
 	 */
-	private volatile ToolCallback[] cachedToolCallbacks;
+	private final AtomicReference<ToolCallback[]> cachedToolCallbacks = new AtomicReference<>();
 
 	/**
 	 * Constructs a new OpenApiMcpToolCallbackProvider.
@@ -117,14 +118,14 @@ public OpenApiMcpToolCallbackProvider(OpenAPIService openAPIService,
 
 	@Override
 	public ToolCallback[] getToolCallbacks() {
-		ToolCallback[] cached = this.cachedToolCallbacks;
+		ToolCallback[] cached = this.cachedToolCallbacks.get();
 		if (cached != null) {
 			return cached;
 		}
 		OpenAPI openAPI = openAPIService.getCachedOpenAPI(Locale.getDefault());
 		if (openAPI != null) {
 			cached = buildToolCallbacks(openAPI);
-			this.cachedToolCallbacks = cached;
+			this.cachedToolCallbacks.set(cached);
 			return cached;
 		}
 		return new ToolCallback[0];
@@ -184,7 +185,7 @@ ToolCallback[] buildToolCallbacks(OpenAPI openAPI) {
 	 * {@link #getToolCallbacks()} rebuilds them.
 	 */
 	void resetCache() {
-		this.cachedToolCallbacks = null;
+		this.cachedToolCallbacks.set(null);
 	}
 
 	/**

springdoc-openapi-starter-common/src/main/java/org/springdoc/api/AbstractMultipleOpenApiResource.java

@@ -28,7 +28,6 @@
 
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.stream.Collectors;
 
 import org.springdoc.core.customizers.SpringDocCustomizers;

springdoc-openapi-starter-common/src/main/java/org/springdoc/core/configuration/SpringDocWebServerConfiguration.java

@@ -1,5 +1,6 @@
 package org.springdoc.core.configuration;
 
+import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Supplier;
 
 import org.apache.commons.lang3.StringUtils;
@@ -48,9 +49,9 @@ static final class SpringDocWebServerPortListener
 
             private final String contextPath;
 
-            private volatile Supplier<Integer> applicationPortSupplier;
-            private volatile Supplier<Integer> actuatorPortSupplier;
-            private volatile Supplier<ApplicationContext> managementContextSupplier;
+            private final AtomicReference<Supplier<Integer>> applicationPortSupplier = new AtomicReference<>();
+            private final AtomicReference<Supplier<Integer>> actuatorPortSupplier = new AtomicReference<>();
+            private final AtomicReference<Supplier<ApplicationContext>> managementContextSupplier = new AtomicReference<>();
 
             public SpringDocWebServerPortListener(ObjectProvider<ServerProperties> serverPropertiesProvider) {
                 ServerProperties serverProperties = serverPropertiesProvider.getIfAvailable();
@@ -63,27 +64,27 @@ public SpringDocWebServerPortListener(ObjectProvider<ServerProperties> serverPro
             public void onApplicationEvent(WebServerInitializedEvent event) {
                 final WebServer webServer = event.getWebServer();
                 if (WebServerApplicationContext.hasServerNamespace(event.getApplicationContext(), "management")) {
-                    this.actuatorPortSupplier = webServer::getPort;
-                    this.managementContextSupplier = event::getApplicationContext;
+                    this.actuatorPortSupplier.set(webServer::getPort);
+                    this.managementContextSupplier.set(event::getApplicationContext);
                 }
                 else {
-                    this.applicationPortSupplier = webServer::getPort;
+                    this.applicationPortSupplier.set(webServer::getPort);
                 }
             }
 
             @Override
             public Supplier<Integer> getApplicationPort() {
-                return applicationPortSupplier;
+                return applicationPortSupplier.get();
             }
 
             @Override
             public Supplier<Integer> getActuatorPort() {
-                return actuatorPortSupplier;
+                return actuatorPortSupplier.get();
             }
 
             @Override
             public Supplier<ApplicationContext> getManagementApplicationContext() {
-                return this.managementContextSupplier;
+                return this.managementContextSupplier.get();
             }
 
             @Override

springdoc-openapi-starter-common/src/main/java/org/springdoc/core/data/DataRestResponseService.java

@@ -295,11 +295,10 @@ private Type getTypeForCollectionModel(Class returnedEntityType, boolean pagingR
 	private Type getTypeForWildcardType(RequestMethod requestMethod, DataRestRepository dataRestRepository, Class returnedEntityType, ParameterizedType parameterizedType) {
 		WildcardType wildcardType = (WildcardType) parameterizedType.getActualTypeArguments()[0];
 		Class<?> type = findType(requestMethod, dataRestRepository);
-		if (wildcardType.getUpperBounds()[0] instanceof ParameterizedType wildcardTypeUpperBound) {
-			if (RepresentationModel.class.equals(wildcardTypeUpperBound.getRawType())) {
-				if (MapModel.class.equals(type))
-					return ResolvableType.forClassWithGenerics(ResponseEntity.class, type).getType();
-			}
+		if (wildcardType.getUpperBounds()[0] instanceof ParameterizedType wildcardTypeUpperBound
+				&& RepresentationModel.class.equals(wildcardTypeUpperBound.getRawType())
+				&& MapModel.class.equals(type)) {
+			return ResolvableType.forClassWithGenerics(ResponseEntity.class, type).getType();
 		}
 		return resolveGenericType(ResponseEntity.class, type, returnedEntityType);
 	}

springdoc-openapi-starter-common/src/main/java/org/springdoc/core/providers/SpringWebProvider.java

@@ -25,7 +25,7 @@
  */
 package org.springdoc.core.providers;
 
-import java.util.HashMap;
+import java.util.EnumMap;
 import java.util.Map;
 import java.util.Set;
 
@@ -66,7 +66,7 @@ public abstract class SpringWebProvider implements ApplicationContextAware {
 	/**
 	 * The Spring doc version strategy map.
 	 */
-	protected final Map<SpringDocApiVersionType, SpringDocVersionStrategy> springDocVersionStrategyMap = new HashMap<>();
+	protected final Map<SpringDocApiVersionType, SpringDocVersionStrategy> springDocVersionStrategyMap = new EnumMap<>(SpringDocApiVersionType.class);
 
 	/**
 	 * Gets handler methods.

springdoc-openapi-starter-common/src/main/java/org/springdoc/core/utils/SpringSecurityUtils.java

@@ -38,6 +38,9 @@
  */
 public final class SpringSecurityUtils {
 
+	private SpringSecurityUtils() {
+	}
+
 	/**
 	 * Gets path.
 	 *

springdoc-openapi-starter-webflux-api/src/main/java/org/springdoc/webflux/core/visitor/RouterFunctionVisitor.java

@@ -52,6 +52,25 @@
  */
 public class RouterFunctionVisitor extends AbstractRouterFunctionVisitor implements RouterFunctions.Visitor, RequestPredicates.Visitor {
 
+	/**
+	 * The package-private {@code PathResourceLookupFunction} type, resolved reflectively
+	 * since it is not accessible for a direct {@code instanceof} check.
+	 */
+	private static final Class<?> PATH_RESOURCE_LOOKUP_FUNCTION = resolvePathResourceLookupFunction();
+
+	/**
+	 * Resolves the package-private {@code PathResourceLookupFunction} class.
+	 * @return the class, or {@code null} if it cannot be found
+	 */
+	private static Class<?> resolvePathResourceLookupFunction() {
+		try {
+			return Class.forName("org.springframework.web.reactive.function.server.PathResourceLookupFunction");
+		}
+		catch (ClassNotFoundException ex) {
+			return null;
+		}
+	}
+
 	@Override
 	public void route(RequestPredicate predicate, HandlerFunction<?> handlerFunction) {
 		this.currentRouterFunctionDatas = new ArrayList<>();
@@ -72,7 +91,7 @@ public void endNested(RequestPredicate predicate) {
 
 	@Override
 	public void resources(Function<ServerRequest, Mono<Resource>> lookupFunction) {
-		if ("PathResourceLookupFunction".equals(lookupFunction.getClass().getSimpleName())) {
+		if (PATH_RESOURCE_LOOKUP_FUNCTION != null && PATH_RESOURCE_LOOKUP_FUNCTION.isInstance(lookupFunction)) {
 			Field patternField = ReflectionUtils.findField(lookupFunction.getClass(), "pattern");
 			if (patternField != null) {
 				ReflectionUtils.makeAccessible(patternField);