Skip to content

Fix a few gradle issues #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix a few gradle issues #103

merged 2 commits into from
Aug 15, 2023

Conversation

Sineaggi
Copy link

@Sineaggi Sineaggi commented Mar 1, 2023

  • Changes workingDir from file property to directory property
  • Changes sets to conventions
  • Registers tasks before afterEvaluate (but continue to configure them in afterEvaluate)
  • Changes workingDir fallback to tempDir, as the upstream plugin is erroneously setting workingDir to @Input (instead of @Internal)
  • Sets default output dir to openapi instead of buildDir to prevent issues with gradle's dependency tracking

@Sineaggi
Copy link
Author

Sineaggi commented Mar 1, 2023

May resolve some of the issues seen in #102

@westse
Copy link
Contributor

westse commented Aug 14, 2023

These are all good changes. Can this be merged, or at least a comment on why not?

@bnasslahsen
Copy link
Contributor

Will be merged soon !

@bnasslahsen bnasslahsen merged commit f1725e2 into springdoc:master Aug 15, 2023
@bnasslahsen
Copy link
Contributor

@Sineaggi,

Thank you for your contribution to the project.

@bnasslahsen bnasslahsen mentioned this pull request Aug 15, 2023
Closed
@Sineaggi Sineaggi deleted the fix-gradle-issues branch August 15, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sineaggi @westse @bnasslahsen