Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validation] more false positives for missing configuration validation #1292

Open
martinlippert opened this issue Jul 15, 2024 · 0 comments
Open
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: bug
Milestone

Comments

@martinlippert
Copy link
Member

The validation to find missing @Configuration annotations on classes that contain @Bean methods needs to be improved. This is related to #1100.

The beans in "lite-mode" can be defined via @Bean methods basically on any Spring component, whether that is annotated with @Configuration or not, as long as the containing class is a Spring component. So we need to refine this validation to take this into account.

That means as soon as the class is annotated with @Component (or any sub-annotations of that), the validation should not be triggered.

In addition to that (checking for the annotation), the validation needs to take additional cases into account where a class turns into a Spring component without being annotated at all (e.g. the Feign case from #1100, Spring Data repositories, maybe more).

@martinlippert martinlippert added type: bug for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation labels Jul 15, 2024
@martinlippert martinlippert added this to the Backlog milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: bug
Projects
None yet
Development

No branches or pull requests

2 participants