Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spring index] optimize super type information for beans with hash codes instead of strings #1045

Open
martinlippert opened this issue May 10, 2023 · 0 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement
Milestone

Comments

@martinlippert
Copy link
Member

The only purpose of keeping all the super types of a bean type within the spring index is to check for type compatibility. This could be optimized in a way to not store the fully qualified type information as strings in the index storage, but hash codes only (and then compare hash codes instead of type strings).

While this seems to be straight forward and easy to do, we need to verify that this covers all the ways a bean is being found when looking for a compatible bean. Generics might be a potential complicated case here, but we need to double check while implementing this optimization here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant