Quickfix for missing property in .properties / .yml editor

[kdvolder]

This used to work in the old editor. The quickfix would generate some .json metadata to 'define' the property and make the warning go away. The new LSP based editor doesn't have a quickfix for this case.

See: #97

[mathisdt]

It would be nice to have an option to disable these warnings altogether so the "Problems" view doesn't get too filled up. Sometimes a project uses its own property keys which may be unknown to Spring Boot but are nevertheless valid properties.

[kdvolder]

@mathisdt That's a good point. The old/legacy version of the editor used to have a way to configure problem severity for different types of probems, setting the severity to 'ignore' would make those types of errors disapear completely.

So I agree we should bring something like this back in the new editor too.

I did want to react to something you said though.

Sometimes a project uses its own property keys which may be unknown to Spring Boot but are nevertheless valid properties.

If you defined the properties in the right way, using classes annotated with @ConfigurationProperties and using the spring boot 'configuration processor' then in theory your project's properties would work just the same is those built in with spring boot libraries. So they shouldn't cause 'unknown property' warnings. This would really be the best/ideal solution.

Now, I know there's probably all kinds of practical reasons why this wasn't done, can't be done, is too much work to do, not yet done, etc. So I still take your point that it would be a good idea for the editor to provide some mechanic for users to disable these warnings.

[spring-projects-issues]

(comment in Pivotal Tracker added by Alex Boyko:)

@krisde this seems to be "unknown" property quick fix rather than "missing" property quick fix issue. Is that correct? In other words the quick fix adding pom content to generate properties metadata json is missing. Is that right?

[spring-projects-issues]

(comment in Pivotal Tracker added by Alex Boyko:)

"Create metadata for <property" is the quick fix we are missing it looks like.

[martinlippert]

We should also integrate an easy way to configure the problem severity, so that people could select "ignore" or something like this for this warning (in general).

[kdvolder]

We should also integrate an easy way to configure the problem severity, so that people could select "ignore" or something like this for this warning (in general).

WE used to have this in STS 3. But its one of the features that wasn't re-implemented in the language server context. The architecture however is still such that problem severities are decoupled from problem types so that it shouldn't be too hard to get this working again.

The main difficulty is, probably, that this kind of 'configuration' will have to be done via LSP configuration keys. I think this is complex enough that we should treat this as a separate issue ticket.

[spring-projects-issues]

(comment in Pivotal Tracker added by Alex Boyko:)

Fixed but both LSP4E and VSCode don't save documents edited when Workspace Edit is performed. Therefore, the json file is opened in the editor but not saved. All need to be saved then the warning goes away.
LSP4E has this bug currently: https://bugs.eclipse.org/bugs/show_bug.cgi?id=543435 Doesn't allow to make text edits to files that don't exists eventhough previous change from the workspace edit creates this file. This should be fixed rather soon.