Skip to content

Replace deprecated command with environment file #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Replace deprecated command with environment file #658

merged 1 commit into from
Feb 8, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Feb 5, 2023

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Resolve #657

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find .github/workflows -name '*.yml' | xargs egrep '\bset-output\b'

AS-IS

run: |
  echo "::set-output name=project-version::$PROJECT_VERSION"

TO-BE

run: |
  echo "project-version=$PROJECT_VERSION" >> $GITHUB_OUTPUT

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@jvalkeal
Copy link
Contributor

jvalkeal commented Feb 5, 2023

Thanks! I was on my radar but you got it first.

@jvalkeal jvalkeal added this to the 3.1.0-M1 milestone Feb 5, 2023
@jvalkeal
Copy link
Contributor

jvalkeal commented Feb 5, 2023

I can handle backporting same time when this get merged.

@jvalkeal jvalkeal merged commit 87914b2 into spring-projects:main Feb 8, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch February 8, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants