Skip to content

Polish usage of spring-boot-testcontainers #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Apr 16, 2025

No description provided.

@rwinch
Copy link
Member

rwinch commented Apr 21, 2025

Thanks for the pull request @quaff! Could you please fix the build failure?

Caused by: org.gradle.api.internal.tasks.compile.CompilationFailedException: Compilation failed; see the compiler output below.
/home/runner/work/spring-session/spring-session/spring-session-samples/spring-session-sample-boot-reactive-redis-indexed/src/test/java/com/example/TestcontainersConfig.java:30: error: cannot find symbol
	RedisContainer redisContainer() {
	^
  symbol:   class RedisContainer
  location: class TestcontainersConfig
/home/runner/work/spring-session/spring-session/spring-session-samples/spring-session-sample-boot-reactive-redis-indexed/src/test/java/com/example/TestcontainersConfig.java:31: error: cannot find symbol
		return new RedisContainer(DockerImageName.parse("redis:6.2.6"));
		           ^
  symbol:   class RedisContainer
  location: class TestcontainersConfig
2 errors
	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:84)
	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:46)
	at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:98)

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff
Copy link
Contributor Author

quaff commented Apr 22, 2025

@rwinch Fixed now.

The failed test passes on my machine.

> Task :spring-session-data-redis:integrationTest

ReactiveRedisIndexedSessionRepositoryITests > findByPrincipalNameWhenExpireKeyEventThenRemovesIndexAndSessionExpiredEvent() FAILED
    java.lang.ClassCastException at ReactiveRedisIndexedSessionRepositoryITests.java:171

@rwinch rwinch self-assigned this Apr 22, 2025
@rwinch rwinch added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 22, 2025
@rwinch rwinch added this to the 3.5.0-RC1 milestone Apr 22, 2025
@rwinch rwinch closed this Apr 22, 2025
@rwinch rwinch reopened this Apr 22, 2025
@rwinch rwinch merged commit a965117 into spring-projects:main Apr 22, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants