Skip to content

Replace JSR-250 annotations with standard Spring lifecycle callbacks #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Sep 23, 2022

This aligns the codebase with remarks from #2163 (review).

Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove the jakarta.annotation-api dependency at this point?

@vpavic vpavic force-pushed the lifecycle-callbacks branch from 867afdb to c2f8c7d Compare September 23, 2022 20:51
@vpavic
Copy link
Contributor Author

vpavic commented Sep 23, 2022

Is it possible to remove the jakarta.annotation-api dependency at this point?

Good catch - I forgot to remove it from core, and subsequently, from the dependency management altogether.

That's done now.

@rwinch rwinch merged commit 4b34f35 into spring-projects:main Sep 26, 2022
@rwinch rwinch self-assigned this Sep 26, 2022
@rwinch rwinch added in: core type: enhancement A general enhancement labels Sep 26, 2022
@rwinch rwinch added this to the 3.0.0-RC1 milestone Sep 26, 2022
@rwinch
Copy link
Member

rwinch commented Sep 26, 2022

Thanks for the Pull Request! This is now merged into main 😄

@vpavic vpavic deleted the lifecycle-callbacks branch September 26, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants