Restructure Redis HttpSession configuration support #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavic
force-pushed
the
redis-httpsession-config
branch
5 times, most recently
from
be49463 to
7916f8f
Compare
vpavic
changed the title
vpavic
force-pushed
the
redis-httpsession-config
branch
from
7916f8f to
6c8fd80
Compare
This reverts commit 8582b97 See spring-projectsgh-2122
This commit restructures configuration support for Redis-backed HttpSession with aim to enable users to easily select the SessionRepository implementation they prefer to use. This is achieved by introducing [at]EnableRedisIndexedHttpSession annotation that can be used to configure RedisIndexedSessionRepository, while the existing [at]EnableRedisHttpSession will going forward configure RedisSessionRepository as the SessionRepository implementation used by Spring Session. Additionally, this also introduces AbstractRedisHttpSessionConfiguration as the base configuration class that manages common aspects of Redis-backed HttpSession support, which is then extended by more specific configuration classes that provide specific SessionRepository implementation. Closes spring-projectsgh-2122
vpavic
force-pushed
the
redis-httpsession-config
branch
from
6c8fd80 to
e1757d2
Compare
|
I've rebased the PR on top of the current I considered the documentation updates while putting the PR together, however with all the changes that happened during the lifecycle of 2.x (that were unfortunately not documented in timely manner) and now these changes I feel that the docs are better addressed via #1010 as a part of larger overhaul. That's one topic I believe we should discuss when we jump on the next sync. In the meantime, I wouldn't hold this up, especially since spring-projects/spring-boot#32205 is likely to get merged soon as well. |
vpavic
commented
Sep 7, 2022
...edis/src/main/java/org/springframework/session/data/redis/RedisIndexedSessionRepository.java
Show resolved
Hide resolved
rwinch
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts 8582b97 and restructures configuration support for Redis-backed
HttpSessionwith aim to enable users to easily select theSessionRepositoryimplementation they prefer to use.This is achieved by introducing
@EnableRedisIndexedHttpSessionannotation that can be used to configureRedisIndexedSessionRepository, while the existing@EnableRedisHttpSessionwill going forward configureRedisSessionRepositoryas theSessionRepositoryimplementation used by Spring Session.Additionally, this also introduces
AbstractRedisHttpSessionConfigurationas the base configuration class that manages common aspects of Redis-backedHttpSessionsupport, which is then extended by more specific configuration classes that provide specificSessionRepositoryimplementation.Closes #2122