SEC-2083: Created a class that allows filtering of immutable collections...

[matsev]

This is a suggestion on how the suggestion in https://jira.springsource.org/browse/SEC-2083 can be implemented. I was hesitating whether or not to extend the DefaultMethodSecurityExpressionHandler for this use case, or refactor it to form an AbstractMethodSecurityExpressionHandler that could be extended. Personally, I prefer the latter, but with the provided solution no existing code is changed.

[pivotal-issuemaster]

@matsev Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@matsev Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[vborcea]

this tow ifs could be combined:
if(debug){

•        logger.debug("Filtering with expression: " + filterExpression.getExpressionString());
  

•        logger.debug("Filtering collection with " + filterTarget.size() + " elements");
  

•    }
  

[pivotal-issuemaster]

@matsev Thank you for signing the Contributor License Agreement!

[eleftherias]

@matsev I'm moving the discussion from gh-2316 to this thread for better visibility.

Thanks for the submission. I think I would prefer a strategy style pattern rather than inheritance. This would allow handling of custom types. One issue I see w/ the pull request is it does not seem to consider that some users may use specific types of collections. For example, if the method signature were a LinkedList this solution does not look like it would work since LinkedList is a List and the solution would use an ArrayList. A PR that would be merged would certainly need some tests to demonstrate these use cases working.

Let us know if you are interested in modifying the PR according to the comment above.

[matsev]

@eleftherias I am sorry, but I have no intention of updating the PR.

After reading back, I recall the the problem I had back then, but I changed projects a long time ago. Supporting immutable collections still seems like good idea though, feel free to modify the PR in any way you find suitable.