Skip to content

Update HandlerMappingIntrospector Usage in CORS support #16657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

Update HandlerMappingIntrospector Usage in CORS support #16657

merged 1 commit into from
Mar 26, 2025

Conversation

evgeniycheban
Copy link
Contributor

Closes gh-16501

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 26, 2025
@evgeniycheban evgeniycheban force-pushed the gh-16501 branch 3 times, most recently from f3aadd2 to 2275030 Compare March 1, 2025 21:39
@jzheaux jzheaux self-assigned this Mar 18, 2025
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement labels Mar 18, 2025
jzheaux
jzheaux requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! I've left some feedback inline.

@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 19, 2025
@evgeniycheban evgeniycheban requested a review from jzheaux March 22, 2025 17:01
jzheaux
jzheaux requested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! I think we still need to lookup the CorsConfigurationSource by name, please see my inline comment.

@jzheaux jzheaux removed the status: waiting-for-feedback We need additional information before we can continue label Mar 25, 2025
@evgeniycheban evgeniycheban requested a review from jzheaux March 25, 2025 23:12
@evgeniycheban
Copy link
Contributor Author

@jzheaux I have updated the PR

@evgeniycheban
Update HandlerMappingIntrospector Usage in CORS support
5cb6ef4 
Closes spring-projectsgh-16501

Signed-off-by: Evgeniy Cheban <mister.cheban@gmail.com>
@jzheaux jzheaux merged commit ad1ee28 into spring-projects:main Mar 26, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Mar 26, 2025

Thanks, @evgeniycheban! This is now merged into main. I also added a polish to use containsBean: e65e32b

@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
Spring Security Team
Status: No status
Milestone
6.5.0-RC1
Development

Successfully merging this pull request may close these issues.

Update HandlerMappingIntrospector Usage in CORS support
3 participants
@evgeniycheban @jzheaux @spring-projects-issues