-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Remove Deprecated Usages of RemoteJWKSet #16296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kwondh5217, for the PR! I've left some feedback inline.
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
holzerch
reviewed
Jan 17, 2025
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoder.java
Outdated
Show resolved
Hide resolved
close spring-projectsgh-16251 Signed-off-by: Daeho Kwon <trewq231@naver.com>
close spring-projectsgh-16251 Signed-off-by: Daeho Kwon <trewq231@naver.com>
close spring-projectsgh-16251 Signed-off-by: Daeho Kwon <trewq231@naver.com>
close spring-projectsgh-16251 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16276 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16276 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-7273 Signed-off-by: Daeho Kwon <trewq231@naver.com>
This places the new functionality behind a setting so that we can remain passive until we can change the setting in the next major release. Issue spring-projectsgh-7273 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-14915 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16086 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16206 Signed-off-by: Daeho Kwon <trewq231@naver.com>
- Move to the web.authentication.session package since it is only needed by web.authentication.session elements and does not access any other web element itself. - Add Kotlin support - Add documentation Issue spring-projectsgh-16206 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.hibernate.orm:hibernate-core](https://github.com/hibernate/hibernate-orm) from 6.6.3.Final to 6.6.4.Final. - [Release notes](https://github.com/hibernate/hibernate-orm/releases) - [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.6.4/changelog.txt) - [Commits](hibernate/hibernate-orm@6.6.3...6.6.4) --- updated-dependencies: - dependency-name: org.hibernate.orm:hibernate-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.5.12 to 1.5.13. - [Commits](https://github.com/qos-ch/logback/commits) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
…itory Closes spring-projectsgh-16093 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16093 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-15982 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-15982 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16213 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.hibernate.orm:hibernate-core](https://github.com/hibernate/hibernate-orm) from 6.6.4.Final to 6.6.5.Final. - [Release notes](https://github.com/hibernate/hibernate-orm/releases) - [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.6.5/changelog.txt) - [Commits](hibernate/hibernate-orm@6.6.4...6.6.5) --- updated-dependencies: - dependency-name: org.hibernate.orm:hibernate-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.springframework.data:spring-data-bom](https://github.com/spring-projects/spring-data-bom) from 2024.1.1 to 2024.1.2. - [Release notes](https://github.com/spring-projects/spring-data-bom/releases) - [Commits](spring-projects/spring-data-bom@2024.1.1...2024.1.2) --- updated-dependencies: - dependency-name: org.springframework.data:spring-data-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.27.2 to 3.27.3. - [Release notes](https://github.com/assertj/assertj/releases) - [Commits](assertj/assertj@assertj-build-3.27.2...assertj-build-3.27.3) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.27.0 to 4.28.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](SeleniumHQ/selenium@selenium-4.27.0...selenium-4.28.0) --- updated-dependencies: - dependency-name: org.seleniumhq.selenium:selenium-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16461 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Checks that serialization/deserialization can be performed. Issue spring-projectsgh-16443 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16463 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf> Signed-off-by: Daeho Kwon <trewq231@naver.com>
closes spring-projectsgh-16458 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16443 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16291 Signed-off-by: Max Batischev <mblancer@mail.ru> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [io.freefair.gradle:aspectj-plugin](https://github.com/freefair/gradle-plugins) from 8.11 to 8.12. - [Release notes](https://github.com/freefair/gradle-plugins/releases) - [Commits](freefair/gradle-plugins@8.11...8.12) --- updated-dependencies: - dependency-name: io.freefair.gradle:aspectj-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.htmlunit:htmlunit](https://github.com/HtmlUnit/htmlunit) from 4.8.0 to 4.9.0. - [Release notes](https://github.com/HtmlUnit/htmlunit/releases) - [Commits](HtmlUnit/htmlunit@4.8.0...4.9.0) --- updated-dependencies: - dependency-name: org.htmlunit:htmlunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16276 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16276 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16276 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16276 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps com.github.ben-manes:gradle-versions-plugin from 0.51.0 to 0.52.0. --- updated-dependencies: - dependency-name: com.github.ben-manes:gradle-versions-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.28.0 to 4.28.1. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](https://github.com/SeleniumHQ/selenium/commits) --- updated-dependencies: - dependency-name: org.seleniumhq.selenium:selenium-java dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16482 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Issue spring-projectsgh-16482 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes spring-projectsgh-16251 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Superceded by #16537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: oauth2
An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
status: duplicate
A duplicate of another issue
type: enhancement
A general enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close gh-16251