Skip to content

Add ability to customize AuthenticationManager and AuthorizationManager observation conventions #12753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add ability to customize AuthenticationManager and AuthorizationManager observation conventions #12753

merged 3 commits into from
Mar 28, 2023

Conversation

braunsonm
Copy link
Contributor

Fixes #12534

@pivotal-cla
Copy link

@braunsonm Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@braunsonm Thank you for signing the Contributor License Agreement!

@braunsonm
Copy link
Contributor Author

cc @jzheaux

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2023
jzheaux
jzheaux requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @braunsonm! Sorry it took me a bit to get to reviewing your PR; I've left some feedback inline.

In addition to that inline feedback, will you please add unit tests to confirm that your new functionality works? Please, for example, add a test to ObservationAuthenticationManagerTests and one to each of the other corresponding test classes.

When you are ready to go, please squash all of your commits into one with a commit message that looks something like this:

Support Customizing Observation Conventions

Closes gh-12534

This format integrates with GitHub to close the ticket automatically, which is helpful.

@jzheaux jzheaux self-assigned this Mar 20, 2023
@jzheaux jzheaux added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2023
@braunsonm braunsonm force-pushed the issue-12534-customize-conventions branch from dc1288c to eb11863 Compare March 22, 2023 00:00
@braunsonm
Copy link
Contributor Author

Should be good. There isn't much to test on a setter but I assumed you wanted the assertion tested

@jzheaux jzheaux force-pushed the issue-12534-customize-conventions branch from aec54b2 to 8970352 Compare March 28, 2023 17:52
@jzheaux jzheaux added this to the 6.1.0-M3 milestone Mar 28, 2023
@jzheaux
Polish ObservationConvention Configuration
f0a90a4 
Change to setObservationConvention so that it reads more clearly
when used, for example `authenticationManager.setObservationConvention`
is clearer than `authenticationManager.setConvention`.

Change unit test names to follow team conventions.

Issue spring-projectsgh-12534
@jzheaux jzheaux force-pushed the issue-12534-customize-conventions branch from 6cb538c to f0a90a4 Compare March 28, 2023 18:23
@jzheaux jzheaux merged commit 607e40d into spring-projects:main Mar 28, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Mar 28, 2023

Thanks, @braunsonm! This is now merged into main. I also merged a couple of polish commits, one for general formatting and one to adjust the method name to setObservationConvention for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC1
Development

Successfully merging this pull request may close these issues.

Ability to customize the AuthorizationObservationConvention
4 participants
@braunsonm @pivotal-cla @jzheaux @spring-projects-issues