Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-2886: Session flag to bypass CSRF #3004

Open
spring-projects-issues opened this issue Feb 26, 2015 · 3 comments
Open

SEC-2886: Session flag to bypass CSRF #3004

spring-projects-issues opened this issue Feb 26, 2015 · 3 comments
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: jira An issue that was migrated from JIRA

Comments

@spring-projects-issues
Copy link

Christopher Smith (Migrated from SEC-2886) said:

My application uses identical URI endpoints for both Web and non-Web clients. While I appreciate the importance of CSRF protection for Web interfaces, it would be helpful to be able to specifically tag a session as "this is from a non-Web client and should be ignored by CsrfFilter", probably with a specifically-named attribute. This would provide a straightforward and comprehensible point for implementing per-client CSRF policy.

@spring-projects-issues
Copy link
Author

Rob Winch said:

Does using CsrfFilter's requireCsrfProtectionMatcher work for you? This is a strategy pattern for determining when the CsrfFilter will enforce CSRF protection. By default it is set to execute for POST, PUT, DELETE, etc.

For Java Configuration, you can customize it with the following:

http
    .requireCsrfProtectionMatcher(myCustomRequestMatcher)

XML Based configuration can use csrf@request-matcher-ref.

@spring-projects-issues
Copy link
Author

Christopher Smith said:

That's the approach I'm planning to use, but this seems like a possible general-purpose solution to the common problem, and I wanted to propose having available in the framework (especially for the builder).

@spring-projects-issues spring-projects-issues added in: web An issue in web modules (web, webmvc) Waiting for Feedback type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged Waiting for Feedback labels May 3, 2019
@spring-projects-issues
Copy link
Author

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label May 10, 2019
@rwinch rwinch removed status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-feedback We need additional information before we can continue labels May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Development

No branches or pull requests

2 participants