Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-2120: Include exception message in logs for IllegalStateException in HttpSessionSecurityContextRepository.SaveToSessionResponseWrapper.createNewSessionIfAllowed() #2345

Open
spring-projects-issues opened this issue Jan 14, 2013 · 0 comments
Labels
type: enhancement A general enhancement type: jira An issue that was migrated from JIRA

Comments

@spring-projects-issues
Copy link

alt250 (Migrated from SEC-2120) said:

IllegalStateException exception message should be logged to allow finding the root cause of hard-to-reproduce issues with session creation in this context.
The reason being that "response has been committed" is not the only possible cause.

Stack trace can also be logged in debug mode.

        try {
            return request.getSession(true);
        } catch (IllegalStateException e) {
            // Response must already be committed, therefore can't create a new session
            logger.warn("Failed to create a session, as response has been committed. Unable to store SecurityContext."); <<< add more information here
        }
@spring-projects-issues spring-projects-issues added Open type: enhancement A general enhancement type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@rwinch rwinch removed the Open label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Development

No branches or pull requests

2 participants