Replace Date().getTime() with System.currentTimeMillis()

[openrefactorymunawar]

Overview

In file: KeyBasedPersistenceTokenService.java, there is a method allocateToken that creates a Date object to get the current number of milliseconds. This is inefficient as the Date object is created only to get current milliseconds which can be done in a better way using System.currentTimeMillis().

There are also deprecation issues. Date().getTime() returns the number of milliseconds since January 1, 1970, 00:00:00 GMT. However, this method is deprecated and may not provide accurate results due to time zone issues.

On the other hand, System.currentTimeMillis() returns the current time in milliseconds since January 1, 1970, 00:00:00 GMT in UTC. This method is more reliable and recommended for use.

The fix replaces Date().getTime() with System.currentTimeMillis(), which ensures that the creation time is accurately recorded without any potential issues related to time zones or deprecated methods.

Affected Branches/Tags

• 6.3.3

Affected Versions

• 6.3.3

CLA Requirements:

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

• Git Commit SignOff documentation

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed - to improve global software supply chain security.

The bug is found by running the iCR tool by OpenRefactory, Inc. and then manually triaging the results.

[sjohnr]

Closed via 6f909ef