Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saml2LogoutRequest constructor should check for null values #12775

Open
marcusdacoregio opened this issue Feb 23, 2023 · 3 comments
Open

Saml2LogoutRequest constructor should check for null values #12775

marcusdacoregio opened this issue Feb 23, 2023 · 3 comments
Labels
in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement

Comments

@marcusdacoregio
Copy link
Contributor

Inspired by #12539

The constructor in Saml2LogoutRequest does not check if the parameters received are not null

Expected behavior:

The constructor should use Assert.notNull and related to check if the parameters are valid
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release labels Feb 23, 2023
@marcusdacoregio marcusdacoregio added this to the 7.0.0-M1 milestone Feb 23, 2023
@Anubhav-2000
Copy link
Contributor

Hi, can i take this up?

@Anubhav-2000 Anubhav-2000 mentioned this issue Feb 28, 2023
Closed
@marcusdacoregio
Copy link
Contributor Author

Hi @Anubhav-2000, the problem is that 7.0 is not scheduled yet and we cannot merge it before since this is a breaking change. The main branch is currently the development branch for 6.1.

What do you think of closing the PR for now since it is not gonna be merged soon, and when we have a branch for 7.0 we can reopen it, does it sounds good to you?

@Anubhav-2000
Copy link
Contributor

Hi @marcusdacoregio , sure I have closed it for now.

@marcusdacoregio marcusdacoregio removed this from the 7.0.0-M1 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
2 participants
@marcusdacoregio @Anubhav-2000