Polish ObservationConvention Configuration

Change to setObservationConvention so that it reads more clearly
when used, for example `authenticationManager.setObservationConvention`
is clearer than `authenticationManager.setConvention`.

Change unit test names to follow team conventions.

Issue gh-12534

Author: jzheaux

core/src/main/java/org/springframework/security/authentication/ObservationAuthenticationManager.java

@@ -63,7 +63,7 @@ public Authentication authenticate(Authentication authentication) throws Authent
 	 *
 	 * @since 6.1
 	 */
-	public void setConvention(ObservationConvention<AuthenticationObservationContext> convention) {
+	public void setObservationConvention(ObservationConvention<AuthenticationObservationContext> convention) {
 		Assert.notNull(convention, "The observation convention cannot be null");
 		this.convention = convention;
 	}

core/src/main/java/org/springframework/security/authentication/ObservationReactiveAuthenticationManager.java

@@ -70,7 +70,7 @@ public Mono<Authentication> authenticate(Authentication authentication) throws A
 	 *
 	 * @since 6.1
 	 */
-	public void setConvention(ObservationConvention<AuthenticationObservationContext> convention) {
+	public void setObservationConvention(ObservationConvention<AuthenticationObservationContext> convention) {
 		Assert.notNull(convention, "The observation convention cannot be null");
 		this.convention = convention;
 	}

core/src/main/java/org/springframework/security/authorization/ObservationAuthorizationManager.java

@@ -76,7 +76,7 @@ public AuthorizationDecision check(Supplier<Authentication> authentication, T ob
 	 *
 	 * @since 6.1
 	 */
-	public void setConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
+	public void setObservationConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
 		Assert.notNull(convention, "The observation convention cannot be null");
 		this.convention = convention;
 	}

core/src/main/java/org/springframework/security/authorization/ObservationReactiveAuthorizationManager.java

@@ -75,7 +75,7 @@ public Mono<AuthorizationDecision> check(Mono<Authentication> authentication, T
 	 *
 	 * @since 6.1
 	 */
-	public void setConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
+	public void setObservationConvention(ObservationConvention<AuthorizationObservationContext<?>> convention) {
 		Assert.notNull(convention, "The observation convention cannot be null");
 		this.convention = convention;
 	}

core/src/test/java/org/springframework/security/authentication/ObservationAuthenticationManagerTests.java

@@ -94,8 +94,9 @@ void authenticationWhenErrorsThenObserves() {
 	}
 
 	@Test
-	void conventionSetterThrowsWhenNull() {
-		assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> this.tested.setConvention(null));
+	void setObservationConventionWhenNullThenException() {
+		assertThatExceptionOfType(IllegalArgumentException.class)
+				.isThrownBy(() -> this.tested.setObservationConvention(null));
 	}
 
 }

core/src/test/java/org/springframework/security/authentication/ObservationReactiveAuthenticationManagerTests.java

@@ -97,8 +97,9 @@ void authenticationWhenErrorsThenObserves() {
 	}
 
 	@Test
-	void conventionSetterThrowsWhenNull() {
-		assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> this.tested.setConvention(null));
+	void setObservationConventionWhenNullThenException() {
+		assertThatExceptionOfType(IllegalArgumentException.class)
+				.isThrownBy(() -> this.tested.setObservationConvention(null));
 	}
 
 }

core/src/test/java/org/springframework/security/authorization/ObservationAuthorizationManagerTests.java

@@ -119,8 +119,9 @@ void verifyWhenLooksUpAuthenticationThenObserves() {
 	}
 
 	@Test
-	void conventionSetterThrowsWhenNull() {
-		assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> this.tested.setConvention(null));
+	void setObservationConventionWhenNullThenException() {
+		assertThatExceptionOfType(IllegalArgumentException.class)
+				.isThrownBy(() -> this.tested.setObservationConvention(null));
 	}
 
 }

core/src/test/java/org/springframework/security/authorization/ObservationReactiveAuthorizationManagerTests.java

@@ -118,8 +118,9 @@ void verifyWhenLooksUpAuthenticationThenObserves() {
 	}
 
 	@Test
-	void conventionSetterThrowsWhenNull() {
-		assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> this.tested.setConvention(null));
+	void setObservationConventionWhenNullThenException() {
+		assertThatExceptionOfType(IllegalArgumentException.class)
+				.isThrownBy(() -> this.tested.setObservationConvention(null));
 	}
 
 }