Skip to content

Commit 70891cd

Browse files
Add more information for SAML2 tests failure
1 parent 738463b commit 70891cd

File tree

4 files changed

+55
-4
lines changed

4 files changed

+55
-4
lines changed

servlet/java-configuration/saml2/login/src/integTest/java/example/Saml2JavaConfigurationITests.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,19 @@ void logoutWhenRelyingPartyInitiatedLogoutThenLoginPageWithLogoutParam() throws
8282
HtmlElement rpLogoutButton = home.getHtmlElementById("rp_logout_button");
8383
HtmlPage loginPage = rpLogoutButton.click();
8484
this.webClient.waitForBackgroundJavaScript(10000);
85-
assertThat(loginPage.getUrl().getFile()).isEqualTo("/login?logout");
85+
List<String> urls = new ArrayList<>();
86+
urls.add(loginPage.getUrl().getFile());
87+
urls.add(((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).getUrl().getFile());
88+
assertThat(urls).withFailMessage(() -> {
89+
// @formatter:off
90+
String builder = loginPage.asXml()
91+
+ "\n\n\n"
92+
+ "Enclosing Page"
93+
+ "\n\n\n"
94+
+ ((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).asXml();
95+
// @formatter:on
96+
return builder;
97+
}).contains("/login?logout");
8698
}
8799

88100
private void performLogin() throws Exception {

servlet/spring-boot/java/saml2/login-single-tenant/src/integTest/java/example/Saml2LoginApplicationITests.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,19 @@ void logoutWhenRelyingPartyInitiatedLogoutThenLoginPageWithLogoutParam() throws
6363
HtmlElement rpLogoutButton = home.getHtmlElementById("rp_logout_button");
6464
HtmlPage loginPage = rpLogoutButton.click();
6565
this.webClient.waitForBackgroundJavaScript(10000);
66-
assertThat(loginPage.getUrl().getFile()).isEqualTo("/login?logout");
66+
List<String> urls = new ArrayList<>();
67+
urls.add(loginPage.getUrl().getFile());
68+
urls.add(((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).getUrl().getFile());
69+
assertThat(urls).withFailMessage(() -> {
70+
// @formatter:off
71+
String builder = loginPage.asXml()
72+
+ "\n\n\n"
73+
+ "Enclosing Page"
74+
+ "\n\n\n"
75+
+ ((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).asXml();
76+
// @formatter:on
77+
return builder;
78+
}).contains("/login?logout");
6779
}
6880

6981
private void performLogin() throws Exception {

servlet/spring-boot/java/saml2/login/src/integTest/java/example/Saml2LoginApplicationITests.java

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616

1717
package example;
1818

19+
import java.util.ArrayList;
20+
import java.util.List;
21+
1922
import com.gargoylesoftware.htmlunit.ElementNotFoundException;
2023
import com.gargoylesoftware.htmlunit.WebClient;
2124
import com.gargoylesoftware.htmlunit.html.HtmlElement;
@@ -63,7 +66,19 @@ void logoutWhenRelyingPartyInitiatedLogoutThenLoginPageWithLogoutParam() throws
6366
HtmlElement rpLogoutButton = home.getHtmlElementById("rp_logout_button");
6467
HtmlPage loginPage = rpLogoutButton.click();
6568
this.webClient.waitForBackgroundJavaScript(10000);
66-
assertThat(loginPage.getUrl().getFile()).isEqualTo("/login?logout");
69+
List<String> urls = new ArrayList<>();
70+
urls.add(loginPage.getUrl().getFile());
71+
urls.add(((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).getUrl().getFile());
72+
assertThat(urls).withFailMessage(() -> {
73+
// @formatter:off
74+
String builder = loginPage.asXml()
75+
+ "\n\n\n"
76+
+ "Enclosing Page"
77+
+ "\n\n\n"
78+
+ ((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).asXml();
79+
// @formatter:on
80+
return builder;
81+
}).contains("/login?logout");
6782
}
6883

6984
private void performLogin() throws Exception {

servlet/xml/java/saml2/login-logout/src/integTest/java/example/Saml2XmlITests.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,19 @@ void logoutWhenRelyingPartyInitiatedLogoutThenLoginPageWithLogoutParam() throws
8080
HtmlElement rpLogoutButton = home.getHtmlElementById("rp_logout_button");
8181
HtmlPage loginPage = rpLogoutButton.click();
8282
this.webClient.waitForBackgroundJavaScript(10000);
83-
assertThat(loginPage.getUrl().getFile()).isEqualTo("/login?logout");
83+
List<String> urls = new ArrayList<>();
84+
urls.add(loginPage.getUrl().getFile());
85+
urls.add(((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).getUrl().getFile());
86+
assertThat(urls).withFailMessage(() -> {
87+
// @formatter:off
88+
String builder = loginPage.asXml()
89+
+ "\n\n\n"
90+
+ "Enclosing Page"
91+
+ "\n\n\n"
92+
+ ((HtmlPage) this.webClient.getCurrentWindow().getEnclosedPage()).asXml();
93+
// @formatter:on
94+
return builder;
95+
}).contains("/login?logout");
8496
}
8597

8698
private void performLogin() throws Exception {

0 commit comments

Comments
 (0)