Skip to content

Update for jdk1.7.0 >= u25: use CallerSensitive annotation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleastre
Copy link

I had like many others problem running grails applications using the latest jdk version.

As I still have problems with the fedora openjdk (based on and early icedtea 2.3.10), I tried to replace the getCallerClass(depth) calls with the new CallerSensitive annotation (see http://openjdk.java.net/jeps/176).

This pull request is a proof of concept that breaks compatibility with older jdk releases, but can be useful for future jdk updates.

Tests seems to pass and grails applications are running correctly.

@ghost
Copy link

ghost commented Jul 18, 2013

Please can you explain better what I have to do? Sorry for my ignorance, I'm really disappointed for this bug.

@oleastre
Copy link
Author

I suppose you are coming from the grails bug report.

You can either try to clone my branch of spring-loaded, compile and package it yourself.
Or use the jar file I putted there: http://www.oleastre.be/export/springloaded-1.1.3.jar (without any warranty it works)

Then replace the grails 2.2.3 springloaded jar with the new one (as explaine in grails jira.)

@ghost
Copy link

ghost commented Jul 18, 2013

On 19 July 2013 00:03, Olivier Samyn notifications@github.com wrote:

I suppose you are coming from the grails bug report.

You can either try to clone my branch of spring-loaded, compile and
package it yourself.
Or use the jar file I putted there:
http://www.oleastre.be/export/springloaded-1.1.3.jar (without any
warranty it works)

Then replace the grails 2.2.3 springloaded jar with the new one (as
explaine in grails jira.)

I don't find springloaded-1.1.3.jar but

./lib/org.springsource.springloaded/springloaded-core/jars/springloaded-core-1.1.3.jar

@ghost
Copy link

ghost commented Jul 18, 2013

yesssssssssssssss, I've copied and renamed to springloaded-core-1.1.3.jar your file and all seems to work.
Really thank you soooooooooo much :)

@aclement
Copy link
Contributor

I'd rather not break the behaviour on the older JDKs at the moment, so we need a fix that doesn't cause that problem. But I guess I could put this into a branch of the main repo as I'm not sure when I'll have time to do a proper solution that supports old and new jdk levels.

@rascio
Copy link

rascio commented Dec 10, 2013

Hi,
Is there any news/update for this problem?

@arthinking
Copy link

So the this solution is above written by oleastre ? :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants