Remove TODO comment and unnecessary null checks for getBeanName()#4253
Merged
artembilan merged 1 commit intospring-projects:mainfrom Jan 20, 2026
Merged
Conversation
Contributor
Author
|
I removed the |
Signed-off-by: david-parkk <ji0513ji@naver.com>
9e0ef68 to
8816596
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to resolve the TODO comment in
AbstractMessageListenerContainer.getBeanName()by adding@NonNullannotation and removing what appear to be unnecessary null checks in related classes.Analysis
Based on my understanding of the codebase:
beanNamefield is declared as@NonNullwith default value"noBeanNameSet"getBeanName()should never returnnull@Nullableannotation seems to have been incorrect(getBeanName() == null ? "" : getBeanName())appear to be unnecessaryPlease let me know if I've misunderstood any aspect of this.
Changes
AbstractMessageListenerContainer.java: Remove TODO comment, add@NonNulltogetBeanName()KafkaMessageListenerContainer.java: Remove unnecessary null checkShareKafkaMessageListenerContainer.java: Remove unnecessary null checkTest
Added
shouldSupportDefaultBeanNameSetting()test to verify thatgetBeanName()returns the default value"noBeanNameSet"instead ofnullwhensetBeanName()is not called.I'm happy to make any adjustments based on your feedback. Thank you to the maintainers for taking the time to review this contribution!