GH-9694: Remove duplicate SocketChannel initialization #9696
Conversation
|
@anthologia Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@anthologia Thank you for signing the Contributor License Agreement! |
| @@ -113,6 +115,11 @@ protected TcpConnectionSupport buildNewConnection() { | |||
| return wrappedConnection; | |||
| } | |||
| catch (IOException e) { | |||
| try { | |||
| socketChannel.close(); | |||
There was a problem hiding this comment.
Don't we need to check if socketChannel != null first?
There was a problem hiding this comment.
Ah right, I missed the null check. Thanks for catching that!
| @@ -113,6 +115,11 @@ protected TcpConnectionSupport buildNewConnection() { | |||
| return wrappedConnection; | |||
| } | |||
| catch (IOException e) { | |||
| try { | |||
| socketChannel.close(); | |||
| } catch (IOException e2) { | |||
There was a problem hiding this comment.
Our code style is to have catch on a new line.
You can run locally ./gradlew :spring-integration-ip:check.
There was a problem hiding this comment.
Checked the style guide and fixed it accordingly. Thanks for the feedback :)
Fixes: spring-projects#9694 Issue link: spring-projects#9694 - Add null check before closing socketChannel in catch block - Prevents potential NullPointerException during error handling
|
@anthologia , |
Fixes: #9694
Issue link: #9694