GH-8680: Check DB for table on start #8690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#8680 If database is not initialized properly before application start, we may lose messages at runtime when we fail to insert data into DB * Implement `SmartLifecycle` on `JdbcMessageStore`, `JdbcChannelMessageStore`, `JdbcMetadataStore`, and `DefaultLockRepository` to perform `SELECT COUNT` query in `start()` to fail fast if no required table is present. * Refactor `AbstractJdbcChannelMessageStoreTests` into JUnit 5 and use `MySqlContainerTest` for more coverage * Fix newly failed tests which had DB not initialized before * Exclude `commons-logging` from `commons-dbcp2` dependency to avoid classpath conflict * Document the new feature
garyrussell
suggested changes
Jul 28, 2023
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/lock/DefaultLockRepository.java
Outdated
Show resolved
Hide resolved
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/lock/DefaultLockRepository.java
Show resolved
Hide resolved
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/metadata/JdbcMetadataStore.java
Outdated
Show resolved
Hide resolved
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/metadata/JdbcMetadataStore.java
Outdated
Show resolved
Hide resolved
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/metadata/JdbcMetadataStore.java
Outdated
Show resolved
Hide resolved
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/metadata/JdbcMetadataStore.java
Outdated
Show resolved
Hide resolved
...n-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcChannelMessageStore.java
Outdated
Show resolved
Hide resolved
...egration-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcMessageStore.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <grussell@vmware.com>
… all the SI JDBC components
|
I guess when we are settled with this, we can expose such a property in Spring Boot to disable it globally, for example, for those applications which are working against stable environment with properly managed DB. |
garyrussell
suggested changes
Jul 28, 2023
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/lock/DefaultLockRepository.java
Outdated
Show resolved
Hide resolved
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/metadata/JdbcMetadataStore.java
Outdated
Show resolved
Hide resolved
...n-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcChannelMessageStore.java
Outdated
Show resolved
Hide resolved
...egration-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcMessageStore.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <grussell@vmware.com>
garyrussell
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8680
If database is not initialized properly before application start, we may lose messages at runtime when we fail to insert data into DB
SmartLifecycleonJdbcMessageStore,JdbcChannelMessageStore,JdbcMetadataStore, andDefaultLockRepositoryto performSELECT COUNTquery instart()to fail fast if no required table is present.AbstractJdbcChannelMessageStoreTestsinto JUnit 5 and useMySqlContainerTestfor more coveragecommons-loggingfromcommons-dbcp2dependency to avoid classpath conflict