GH-10083: Apply Nullability to core events, leader, message and resource packages
#10320
Conversation
ngocnhan-tran1996
changed the title
leader, message and resource packagesevents, leader, message and resource packages
Related to: spring-projects#10083 This commit applies Nullability to core `events`, `leader`, `leader.event`, `message` and `resource` packages Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
ngocnhan-tran1996
force-pushed
the
gh-10083-core-module-packages
branch
from
6abb470 to
6a91a4a
Compare
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
| private volatile ResourcePatternResolver patternResolver; | ||
|
|
||
| private volatile CollectionFilter<Resource> filter; | ||
| private volatile @Nullable CollectionFilter<Resource> filter; |
There was a problem hiding this comment.
... and remove volatile on all the properties.
It is really an anti-pattern to change state of the component at runtime.
Therefore, we treat all of them as state fixed after initialization phase.
Therefore, no need in extra ticks over volatile barrier.
| } | ||
| } | ||
| else { | ||
| inputMessage = MessageBuilder.withPayload(new byte[0]).build(); |
There was a problem hiding this comment.
I think it is better to throw an exception instead.
How that happened that AdviceMessage was serialized without an inputMessage?
So, the state is illegal.
WDYT?
There was a problem hiding this comment.
That makes sense. I wasn’t sure about the behavior in this case, so I decided to initialize the value.
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
|
Can we re-run the build? I haven’t touched the related context package. |
I know. Thank you! |
2 participants
Related to: #10083