Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DataIntegrityViolationException instead of DuplicateKeyException as it is recommended by its Javadocs #8998

Closed
artembilan opened this issue Mar 12, 2024 · 0 comments
Closed

Use DataIntegrityViolationException instead of DuplicateKeyException as it is recommended by its Javadocs #8998

artembilan opened this issue Mar 12, 2024 · 0 comments
Labels
(EOL) for: backport-to-6.1.x (EOL) for: backport-to-6.2.x in: jdbc in: mongodb status: backported type: bug
Milestone
6.3.0-M2

Comments

@artembilan
Copy link
Member

Apparently some databases don't throw a proper code to identify a DuplicateKeyException, so better to catch DataIntegrityViolationException with the same meaning.

See more info in: https://stackoverflow.com/questions/78142353/spring-integration-and-spring-batch-transaction-manager-collision
@artembilan artembilan added this to the 6.3.0-M2 milestone Mar 12, 2024
spring-builds pushed a commit that referenced this issue Mar 12, 2024
@artembilan @spring-builds
GH-8998: Catch DataIntegrityViolationException instead
d3f3a4a 
Fixes: #8998

Apparently some databases don't throw a proper code to identify a `DuplicateKeyException`, so better to catch `DataIntegrityViolationException` with the same meaning.

(cherry picked from commit 676733c)
@spring-builds spring-builds mentioned this issue Mar 12, 2024
Closed
artembilan added a commit that referenced this issue Mar 12, 2024
@artembilan
GH-8998: Catch DataIntegrityViolationException instead
306b904 
Fixes: #8998

Apparently some databases don't throw a proper code to identify a `DuplicateKeyException`, so better to catch `DataIntegrityViolationException` with the same meaning.

(cherry picked from commit 676733c)

# Conflicts:
#	spring-integration-jdbc/src/main/java/org/springframework/integration/jdbc/metadata/JdbcMetadataStore.java
#	spring-integration-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcChannelMessageStore.java
@spring-builds spring-builds mentioned this issue Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(EOL) for: backport-to-6.1.x (EOL) for: backport-to-6.2.x in: jdbc in: mongodb status: backported type: bug
Projects
None yet
Milestone
6.3.0-M2
Development

No branches or pull requests
2 participants
@artembilan @spring-builds