Add ValueExtractor for ArgumentValue#737
Add ValueExtractor for ArgumentValue#737bduisenov wants to merge 3 commits intospring-projects:mainfrom
Conversation
|
@bduisenov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bduisenov Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Thanks for the PR.
We probably don't want to put a helper class of this kind at the top of the data package. It could go further below under ~.data.method.annotation.support where we already have other validation support. A test to prove this works would also be nice to have, probably in ValidationHelperTests.
Let me know if you would you like to shape the changes further based on this, or if not we can take it from here.
|
hey @rstoyanchev |
|
hey @rstoyanchev, please take another look. |
|
Thanks for the changes. |
Validation annotations on ArgumentValue are not working as there's no ValueExtractor provided.
For example, this code
ArgumentValue<@NotBlank @Size(min = 2, max = 500) String> namewill not work as expected.Adding ValueExtractor will solve the issue
#736