Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HttpStatusCode consistently in reference guide #32966

Closed
wants to merge 1 commit into from
Closed

Use HttpStatusCode consistently in reference guide #32966

wants to merge 1 commit into from

Conversation

ypyf
Copy link
Contributor

@ypyf ypyf commented Jun 5, 2024

Updated the first argument to onStatus(...) to use HttpStatusCode instead of HttpStatus.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 5, 2024
@snicoll
Copy link
Member

snicoll commented Jun 6, 2024 •
edited
Loading

Thanks for the PR. Both are valid but I can see how we want the doc to be consistent there.

@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 6, 2024
@snicoll snicoll added this to the 6.1.9 milestone Jun 6, 2024
@snicoll snicoll self-assigned this Jun 6, 2024
@snicoll snicoll changed the title Update client-retrieve.adoc Use HttpStatusCode consistently in reference guide Jun 6, 2024
snicoll pushed a commit that referenced this pull request Jun 6, 2024
@ypyf @snicoll
Use HttpStatusCode consistently in reference guide
e12d125 
See gh-32966
@snicoll snicoll closed this in c3a0eaa Jun 6, 2024
@ypyf ypyf deleted the ypyf-patch-1 branch June 6, 2024 09:41
@ypyf
Copy link
Contributor Author

ypyf commented Jun 6, 2024 •
edited
Loading

Thanks for the PR. Both are valid but I can see how we want the doc to be consistent there.

If I understand correctly, Predicate<HttpStatus> could not safely assign to Predicate<HttpStatusCode> although HttpStatus is a subtype of HttpStatusCode.

@snicoll
Copy link
Member

snicoll commented Jun 7, 2024

You're right, I missed the link with the predicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: documentation A documentation task
Projects
None yet
Milestone
6.1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@ypyf @snicoll @spring-projects-issues