Support "--" end of options in SimpleCommandLineArgsParser #31513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclozel
added
in: core
reevik
reviewed
Oct 31, 2023
spring-core/src/main/java/org/springframework/core/env/SimpleCommandLineArgsParser.java
Outdated
Show resolved
Hide resolved
reevik
reviewed
Oct 31, 2023
spring-core/src/main/java/org/springframework/core/env/SimpleCommandLineArgsParser.java
Outdated
Show resolved
Hide resolved
Prior to this commit, the `SimpleCommandLineArgsParser` would reject "--" arguments as invalid. As reported by the community, the POSIX utility conventions (Guideline 10) state that > The first -- argument that is not an option-argument should be > accepted as a delimiter indicating the end of options. > Any following arguments should be treated as operands, even if they > begin with the '-' character. This commit updates `SimpleCommandLineArgsParser` to not reject "--" arguments and instead to consider remaining arguments as non-optional. Fixes spring-projectsgh-21949
|
Thanks @reevik , I've updated my PR. |
snicoll
approved these changes
Feb 15, 2024
snicoll
pushed a commit
that referenced
this pull request
Feb 15, 2024
Prior to this commit, the `SimpleCommandLineArgsParser` would reject "--" arguments as invalid. As reported by the community, the POSIX utility conventions (Guideline 10) state that > The first -- argument that is not an option-argument should be > accepted as a delimiter indicating the end of options. > Any following arguments should be treated as operands, even if they > begin with the '-' character. This commit updates `SimpleCommandLineArgsParser` to not reject "--" arguments and instead to consider remaining arguments as non-optional. See gh-31513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
SimpleCommandLineArgsParserwould reject"--" arguments as invalid. As reported by the community, the POSIX
utility conventions (Guideline 10) state that
This commit updates
SimpleCommandLineArgsParserto not reject "--"arguments and instead to consider remaining arguments as non-optional.
Fixes gh-21949