Skip to content

HttpClient based ClientHttpRequestFactory#30478

Closed
mdeinum wants to merge 1 commit intospring-projects:mainfrom
mdeinum:http-client
Closed

HttpClient based ClientHttpRequestFactory#30478
mdeinum wants to merge 1 commit intospring-projects:mainfrom
mdeinum:http-client

Conversation

@mdeinum
Copy link
Contributor

@mdeinum mdeinum commented May 11, 2023

As JDK17 is now the baseline it is possible to use the HttpClient provided by Java.

@mdeinum
HttpClient based ClientHttpRequestFactory
366e600 
As JDK17 is now the baseline it is possible to use the
HttpClient provided by Java.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 11, 2023
@vpavic vpavic mentioned this pull request Jun 20, 2023
Closed
@poutsma poutsma self-assigned this Jun 20, 2023
@poutsma poutsma added this to the 6.1.0-M2 milestone Jun 28, 2023
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 28, 2023
@poutsma poutsma closed this in 0033eb4 Jun 28, 2023
poutsma added a commit that referenced this pull request Jun 28, 2023
@poutsma
Merge pull request #30478 from mdeinum:http-client
dd57ec9 
* gh-30478:
  Polishing external contribution
  HttpClient based ClientHttpRequestFactory
@poutsma
Copy link
Contributor

poutsma commented Jun 28, 2023 •
edited
Loading

Thank for your submitting this PR, @mdeinum. I made several changes to the PR.

  • Removed duplicate Client in types names, to mirror the reactive versions in org.springframework.http.client.reactive.
  • Removed request buffering in favor of an OutputStream to Flow.Publisher<ByteBuffer> bridge, see OutputStreamPublisher. Thank you, @OlegDokuka!
  • Made request and response types package private, similar to other request and response types in the package.
  • Various other small improvements.

@poutsma poutsma mentioned this pull request Jul 20, 2023
Closed
@alexcrownus
Copy link

alexcrownus commented Aug 10, 2023

JdkClientHttpRequestFactory is not compatible with BufferingClientHttpRequestFactory #31027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@poutsma poutsma

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Milestone

6.1.0-M2

Development

Successfully merging this pull request may close these issues.

4 participants

@mdeinum @poutsma @alexcrownus @spring-projects-issues