Avoid duplicate registration of @ControllerAdvice implementing both RequestBodyAdvice and ResponseBodyAdvice #22638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixbug: duplicate add on ControllerAdvice both RequestBodyAdvice and ResponseBodyAdvice
spring-projects-issues
added
the
status: waiting-for-triage
|
@liquanchen9 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
sbrannen
added
in: web
|
@liquanchen9 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
sbrannen
removed
the
status: waiting-for-triage
|
Good catch. I'm not sure how often people implement If you could sign the CLA and submit a test that was failing before the change that would be greatly appreciated. |
sbrannen
added
the
status: waiting-for-feedback
sbrannen
changed the title
|
Since this is a trivial change, @liquanchen9, we have decided to forgo the requirement to sign the CLA. Thanks for your contribution! |
spring-projects-issues
added
status: backported
sbrannen
removed
the
status: waiting-for-feedback
sbrannen
added a commit
that referenced
this pull request
Mar 26, 2019
Prior to this commit, if a @ControllerAdvice bean implemented both RequestBodyAdvice and ResponseBodyAdvice, it was only supported as RequestBodyAdvice, meaning it was never invoked as ResponseBodyAdvice. This commit revises RequestResponseBodyAdviceChain to ensure that a single bean implementing both types of body advice is in fact handled as both types of advice. See gh-22638
sbrannen
added a commit
that referenced
this pull request
Mar 26, 2019
Prior to this commit, if a @ControllerAdvice bean implemented both RequestBodyAdvice and ResponseBodyAdvice, it was registered twice in RequestMappingHandlerAdapter, leading to duplicate application of the same logic. This commit ensures that such instances are only registered once. Fixes gh-22638
sbrannen
added a commit
that referenced
this pull request
Mar 26, 2019
Prior to this commit, if a @ControllerAdvice bean implemented both RequestBodyAdvice and ResponseBodyAdvice, it was only supported as RequestBodyAdvice, meaning it was never invoked as ResponseBodyAdvice. This commit revises RequestResponseBodyAdviceChain to ensure that a single bean implementing both types of body advice is in fact handled as both types of advice. See gh-22638
sbrannen
added a commit
that referenced
this pull request
Mar 26, 2019
Prior to this commit, if a @ControllerAdvice bean implemented both RequestBodyAdvice and ResponseBodyAdvice, it was registered twice in RequestMappingHandlerAdapter, leading to duplicate application of the same logic. This commit ensures that such instances are only registered once. Fixes gh-22638
|
@liquanchen9 Thank you for signing the Contributor License Agreement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixbug: duplicate add on ControllerAdvice both RequestBodyAdvice and ResponseBodyAdvice