Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support for custom reason in @DisabledInAotMode #33833

Closed
sbrannen opened this issue Nov 1, 2024 · 0 comments
Closed

Introduce support for custom reason in @DisabledInAotMode #33833

sbrannen opened this issue Nov 1, 2024 · 0 comments
Assignees
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Nov 1, 2024

@DisabledInAotMode has a default disabled reason but currently does not provide a mechanism to add a custom reason.

However, almost all condition annotations provided by JUnit Jupiter (@Disabled, @DisabledOnOs, @DisabledForJreRange, etc.) provide an attribute to supply a custom reason. Thus, users of those annotations would likely expect @DisabledInAotMode to support a custom reason as well.

In addition, we already have over 50 places in our own test suite where we could make use of this feature.

@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Nov 1, 2024
@sbrannen sbrannen added this to the 6.2.0 milestone Nov 1, 2024
@sbrannen sbrannen self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant