Skip to content

Remove ServerResponse.AsyncBuilder interface #33736

Closed
@bclozel

Description

In #32710, we introduced a new contract for streaming responses with MVC functional endpoints. While doing, so we introduced a new interface ServerResponse.AsyncBuilder to gather async concerns under the same shared interface (error/complete/timeout).

This avoids duplication, but this also introduces a binary incompatible change that is problematic in case projects want to maintain compatibility with two generations of Spring Framework. While we don't usually guarantee binary compatibility between minor versions, here Spring for GraphQL is relying on that and will not ship a new minor version with the next release train.

Here is an example of a build failure.

We should undo this change and re-introduce it with the next major Spring Framework version.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

in: webIssues in web modules (web, webmvc, webflux, websocket)type: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions